This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove WC Core shipping settings if Cart/Checkout blocks are in use #8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/checkout/inner-blocks/checkout-shipping-method-block/edit.tsx
assets/js/blocks/checkout/inner-blocks/checkout-shipping-methods-block/edit.tsx assets/js/data/cart/reducers.ts assets/js/utils/attributes.ts |
|
Size Change: +1.74 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
7 tasks
wavvves
approved these changes
Mar 9, 2023
This class will store reusable methods relating to Cart/Checkout Blocks, i.e. whether they are used on the Cart/Checkout page.
This will reduce code duplication when checking if the Cart/Checkout blocks are in use on the Cart/Checkout page.
Required because importing from the index causes the validation data store to register twice
This reverts commit 9967dc0.
63a1ddb to
54833ea
Compare
|
Mentioning that a part of this PR was merged https://github.com/woocommerce/woocommerce-blocks/commit/510eec49f3f841bf61c531bf4460efe9a384f3c3#diff-a942a5198733d5fa79[…]34694286a6e49e4R420-R427 in the WC Blocks 9.8.0 release branch via this PR #8718. See the internal discussion p1678712946221229-slack-C8X6Q7XQU. If this PR gets reverted at some point, the bug fix mentioned above should be brought to trunk. |
This was referenced Apr 5, 2023
This was referenced May 24, 2023
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs required to satisfy #7895.
In this PR we remove settings from
WooCommerce -> Settings -> Shipping -> Shipping OptionsSpecifically the options disabled are:
Enable the shipping calculator on the cart pageif the Cart Block is present on the Cart page and,Hide shipping costs until an address is enteredif the Checkout Block is present on the Checkout page.The first setting is controlled by the Cart Block's settings, and the second option should always be
nofor the purposes of getting the correct local pickup rates from the store API, and will be moved to a block setting in a later PR.I also added a utility function to see if the Cart/Checkout blocks are the default experience. This check could be made multiple places over the codebase, so when we spot it we can update it to use the utility function.
It also adds E2E tests to ensure this is working as expected.
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce -> Settings -> Advanced- set the Cart and Checkout pages to pages containing the shortcode cart/checkout experience. Save.WooCommerce -> Settings -> Shipping -> Shipping Options- observe the two options,Hide shipping costs until an address is enteredandEnable the shipping calculator on the cart page.WooCommerce -> Settings -> Advanced- set the Cart page to one containing the Cart Block. Save.WooCommerce -> Settings -> Shipping -> Shipping Options- observe that where the two options were in step 2, only,Hide shipping costs until an address is enteredremains. Ensure it displays correctly and looks OK.WooCommerce -> Settings -> Advanced- set the Checkout page to one containing the Checkout Block. Save.WooCommerce -> Settings -> Shipping -> Shipping Options- observe that where the two options were in step 2 nothing appears.WooCommerce -> Settings -> Advanced- set the Cart page to one containing the Shortcode cart. Save.WooCommerce -> Settings -> Shipping -> Shipping Options- observe that where the two options were in step 2 onlyEnable the shipping calculator on the cart pageappears. Ensure it displays correctly.Expected results
WooCommerce Visibility
Performance Impact
Changelog