Replace placeholder blockified templates with the right one #9579
Conversation
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Hey @gigitux ! I have a few questions here:
- All of these templates are identical for the Products by Category, Products by Tag, and Products by attribute: the only difference is in the code level and is the
queryId, why is that? - Shouldn't we display those as filtered out products, as mentioned on those templates description? In this shape and form, those templates don't differ much from the main Product Catalog (the only difference is really the additional "Term Description" text block).
Screen.Recording.2023-05-25.at.22.01.34.mov
- I'm consistently getting the following error whenever I customize a template and restore it to its original state:
Screen.Recording.2023-05-25.at.22.14.01.mov
Is it a known issue?
…oocommerce/woocommerce-blocks into add/update_blockified_template
Good catch! The
This is one of the limitations of extending the Query Loop block. We can't control the editor side if the block has the "Inherit query from template" enabled. I think that the new Products Collection block will fix this (cc @imanish003 @kmanijak )
It seems that you are using a development version of GB. Can you try without GB? In any case, it isn't related to this PR. Could you open an issue, please? 🙇 |
👍
Gotcha, thanks for clarifying! Out of curiosity, do we have this documented somewhere? Maybe this was already discussed with @shaunandrews, but tagging here just in case (TL;DR: the Products by Attribute, Products By Category, and Products By Tag templates all display the same content and are almost identical to the Product Catalog) (cc @imanish003 @kmanijak )
Is this a known limitation with the latest version of GB, then? I'm glad to open the issue, just wanted to double-check if you were aware of it and/or if we already had an issue opened to get us covered. |
Not sure, I didn't have time to investigate. It could be depended by this code. |
Gotcha, thanks! I did a few tests here, and as it turns out, this error occurs with and without having the GB plugin enabled. Opened #9637 |
Thanks! Let me know if I can merge this PR 🙇 |
I re-ran all tests, and things in general are working as expected, although I'm noticing some differences between the template and the auto-generated code. For example, within the
And for the auto-generated code in the editor for the Products by Tag template we have:
Are we a-ok with those differences? |
Yeah, it is fine. This happens for all the templates that we have. |
There was a problem hiding this comment.
Yeah, it is fine. This happens for all the templates that we have.
Thanks for confirming! I'm approving, but I would also recommend updating the testing instructions for whoever is going to test this for the release, as right now, it states:
Open the code editor.
Be sure that there isn't any difference with the taxonomy-product_attribute.html template.
And none of the templates are identical (theme content is injected in different areas, making them differ).
Yes, "Inherit query from template" determines the query and we cannot control it. In terms of Product Collection it follows the same concept at the moment and I think that's expected - if the query is inherited, that's the setting we should respect, unless I'm misunderstanding this 🤔
I'm not aware of documentation - at the moment of blockifying the templates we recreated the structure of the classic template and Products by Attribute/Tag/Category had the same structure with the little differences to Product Catalog (like Term Description block). Some of the limitations were gathered in pdnLyh-3rD-p2 (example: generic "Archive Title" rather than customized title, which is due to the fact of using a generic block from WC Core). |
This PR replaces the placeholder blockified templates with the right one. This is necessary since we are working on enabling blockified template for the new stores.
taxonomy-product_attribute.htmltemplate except for the<!-- wp:template-part -->Products By Category(file:taxonomy-product_cat.html) andProducts By Tag(file:taxonomy-product_tag.html)WooCommerce Visibility
Performance Impact