This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable blockified templates #9551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
07ecc19 to
b8c5426
Compare
9bb4dd2 to
7fda740
Compare
cb31fee to
acc8358
Compare
…ocks into add/enable-blockified-templates-as-default
This was referenced May 24, 2023
7 tasks
…ocks into add/enable-blockified-templates-as-default
…github.com/woocommerce/woocommerce-blocks into add/enable-blockified-templates-as-default
cf7c11f to
504507f
Compare
|
Hi @gigitux - Can you please clarify that in the testing, I don't need to activate the WooCommerce Blocks stand alone plugin correct? The instructions didn't state this so I wanted to make sure. |
Yes, it is not necessary to activate WC Blocks. I updated the testing instructions! |
roykho
approved these changes
May 30, 2023
14 tasks
tjcafferkey
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks for the testing instructions @gigitux this works as expected, and I can't see anything of concern in the code changes either.
* Add E2E tests * add comment * set worker to 1 * try now * add beforeAll and afterAll hook * restore woocommerce-gutenberg-products-block.php * enable plugin with .wp-env configuration * remove waitForNetworkIdle * Products block: Add e2e tests (#9577) * migrate classic block to Playwright * fix can be inserted more than once tests * migrate classic block to Playwright * fix command * remove old tests * improve E2E tests * skip test * Products block: add E2E pw tests * Add E2E tests * fix E2E test * test now * try now * rename path * set one worker * try now * try now * try now * set 1 worker
This was referenced Jun 1, 2023
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks E2E tests, so there are serial follow-up PRs to fix them:
Please, review them as well!
The goal of this PR is to render the new blocified templates, only when the user:
and don't have a customized template.
In this table, you can see the expected behavior for the different cases:
Fixes #8209
Testing
it is not necessary to activate WC Blocks.
Download zips:
Install the current version of WC Core from wp.org
Build of WooCommerce Core that contains a version of WC Blocks built with this PR. woocommerce.zip
Please, don't rename the name of the zip.
For convenience, in the testing instructions:
pre-update packagefor the plugin installed via wp.org.after-update packagefor the build of WooCommerce Core that contains a version of WC Blocks built with this PR.User Facing Testing
Test 1:
after-update package.Product Catalog,Product Search Results,Products by Category.Products by TagandSingle Productare blockified.Test 2:
after-update package.Product Catalog,Product Search Results,Products by Category,Products by TagandSingle Productare blockified.Test 3:
pre-update package.Product Catalog,Product Search Results,Products by Category,Products by TagandSingle Productrenders the classicWooCommerce Product Grid Block.after-update package.wp_optionthere is a keywc_blocks_use_blockified_product_grid_block_as_templateset tono.Product Catalog,Product Search Results,Products by Category,Products by TagandSingle Productrenders the classicWooCommerce Product Grid Block.wc_blocks_use_blockified_product_grid_block_as_templateand the keywc_blocks_versionfrom the database and remove the plugin.Test 4:
pre-update package.after-update package.wp_optionthere is a keywc_blocks_use_blockified_product_grid_block_as_templateset toyes.Product Catalog,Product Search Results,Products by Category,Products by TagandSingle Productare blockified.wc_blocks_use_blockified_product_grid_block_as_templateand the keywc_blocks_versionfrom the database and remove the plugin.WooCommerce Visibility
Performance Impact
Changelog