This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix/you do not need lodash #9161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/data/cart/push-changes.ts
assets/js/data/collections/reducers.js assets/js/data/schema/reducers.js assets/js/editor-components/grid-layout-control/index.js assets/js/editor-components/utils/index.js |
|
Size Change: +9.55 kB (+1%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
650c04e to
a57875c
Compare
Replace lodash has
Replace lodash mapKeys with function Move mapkeys to utility Create camelCaseKeys which replaces usage of mapKeys
a57875c to
fb4c398
Compare
wavvves
reviewed
Apr 26, 2023
Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
wavvves
approved these changes
Apr 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all usage of
lodashdependency and replaces lodash functions with native functions, or alternative packages, where possible.Since this touched a number of files, it will be easier to review each commit separately since I did it function by function and the commits are small. You can mark these off it it helps with the review.
without56ed6aeisNumberebec4bcdifference380fedbisEmptya8dda6e and e1055c1isObjectd3cd772noop3d51835clamp6c43bb4uniqueIdaae32f2rangee4f77e5has96faef9omitByafad1d6isEqualbe07aeekebabCase2e91696camelCasef466accsnakeCasec10bb11keyby12e5ab6pick8e3bb60cloneDeep8bebf88sortBy75cb6d7pickBy549826bgroupBy16c8bbdflattenanduniqueBy0f5c918setWith13ec113Debounce/throttle was replaced with a mix of custom functions and the
use-debouncepackage. We might be able to refactor more to use hooks in the future but I left this to avoid complex refactoring:To guard against future usage, an ES Lint rule has been added:
Fixes #8642
Testing
Changes should have a degree of e2e and JS test coverage since a broken replacement would have knock on effect to components using that functionality, so take extra case to make sure tests pass across the board.
Beyond this we should smoke test the critical flows, areas touched include:
Changelog