Replace lodash isEmpty with type guard

assets/js/atomic/blocks/product-elements/add-to-cart/block.tsx

@@ -8,7 +8,7 @@ import {
 	useAddToCartFormContext,
 } from '@woocommerce/base-context';
 import { useProductDataContext } from '@woocommerce/shared-context';
-import { isEmpty } from 'lodash';
+import { isEmpty } from '@woocommerce/types';
 import { withProductDataContext } from '@woocommerce/shared-hocs';
 
 /**

assets/js/base/context/hooks/collections/use-collection-data.ts

@@ -3,9 +3,9 @@
  */
 import { useState, useEffect, useMemo } from '@wordpress/element';
 import { useDebounce } from 'use-debounce';
-import { isEmpty, sortBy } from 'lodash';
+import { sortBy } from 'lodash';
 import { useShallowEqual } from '@woocommerce/base-hooks';
-import { objectHasProp } from '@woocommerce/types';
+import { objectHasProp, isEmpty } from '@woocommerce/types';
 
 /**
  * Internal dependencies

assets/js/blocks/featured-items/with-featured-item.tsx

@@ -4,11 +4,10 @@
  * External dependencies
  */
 import type { BlockAlignment } from '@wordpress/blocks';
-import { ProductResponseItem } from '@woocommerce/types';
+import { ProductResponseItem, isEmpty } from '@woocommerce/types';
 import { __experimentalGetSpacingClassesAndStyles as getSpacingClassesAndStyles } from '@wordpress/block-editor';
 import { Icon, Placeholder, Spinner } from '@wordpress/components';
 import classnames from 'classnames';
-import { isEmpty } from 'lodash';
 import { useCallback, useState } from '@wordpress/element';
 import { WP_REST_API_Category } from 'wp-types';
 import { useBorderProps } from '@woocommerce/base-hooks';

assets/js/editor-components/product-control/index.js

@@ -2,7 +2,7 @@
  * External dependencies
  */
 import { __, _n, sprintf } from '@wordpress/i18n';
-import { isEmpty } from 'lodash';
+import { isEmpty } from '@woocommerce/types';
 import PropTypes from 'prop-types';
 import {
 	SearchListControl,

assets/js/types/type-guards/empty.ts

@@ -0,0 +1,8 @@
+export const isEmpty = ( value: unknown ): boolean => {
+	return (
+		value === null ||
+		value === undefined ||
+		( typeof value === 'object' && Object.keys( value ).length === 0 ) ||
+		( typeof value === 'string' && value.trim().length === 0 )
+	);
+};

assets/js/types/type-guards/index.ts

@@ -4,6 +4,7 @@ export * from './error';
 export * from './function';
 export * from './null';
 export * from './number';
+export * from './empty';
 export * from './object';
 export * from './string';
 export * from './attributes';

assets/js/types/type-guards/test/empty.ts

@@ -0,0 +1,25 @@
+/**
+ * External dependencies
+ */
+import { isEmpty } from '@woocommerce/types';
+
+describe( 'Testing isEmpty()', () => {
+	it( 'Correctly handles null', () => {
+		expect( isEmpty( null ) ).toBe( true );
+	} );
+	it( 'Correctly handles undefined', () => {
+		expect( isEmpty( undefined ) ).toBe( true );
+	} );
+	it( 'Correctly handles empty objects', () => {
+		expect( isEmpty( {} ) ).toBe( true );
+	} );
+	it( 'Correctly handles empty arrays', () => {
+		expect( isEmpty( [] ) ).toBe( true );
+	} );
+	it( 'Correctly handles empty strings', () => {
+		expect( isEmpty( '' ) ).toBe( true );
+	} );
+	it( 'Correctly handles object with values', () => {
+		expect( isEmpty( { a: '1' } ) ).toBe( false );
+	} );
+} );