This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarhi-saad
added
skip-changelog
PRs that you don't want to appear in the changelog.
category: tests
labels
Sep 26, 2023
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
tarhi-saad
force-pushed
the
fix/e2e-playwright-tests-temp
branch
from
September 28, 2023 14:05
d18f83d
to
c6cc89e
Compare
tarhi-saad
changed the title
[WIP] Fix failing Playwright E2E tests - temporary PR
Fix failing Playwright E2E tests
Sep 28, 2023
tarunvijwani
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sep 28, 2023
tarhi-saad
force-pushed
the
fix/e2e-playwright-tests-temp
branch
from
September 28, 2023 21:01
c6cc89e
to
3c5f1db
Compare
13 tasks
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes some failing Playwright E2E tests and skips others. We will create tickets after merging this PR to fix these tests.
Fixes #11042
Why
We fixed the failing tests for the Checkout templates. And we skipped 3 Product tests:
1 related to the Product Collection Block
2 related to the Price Filter and All Products Blocks
I recommend bypassing these tests for now and opening a ticket to address them later. I looked into a quick solution, but couldn't identify one.
Testing Instructions
Just ensure all the tests below are green!
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog
N/A