This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
WIP: Fix broken e2e tests #11043
Closed
WIP: Fix broken e2e tests #11043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
13 tasks
|
@nielslange, I've devised a solution in #11055. I recommend we close this PR and work on the new one. Otherwise, we'd have to undo numerous changes from your PR. It would be more straightforward to proceed with the other one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11042
What
Fixing various broken Playwright e2e tests.
Why
To detect problems early, it’s crucial to maintain reliable end-to-end (e2e) tests. When such tests fail, and we merge Pull Requests (PRs) dismissing those failures as simply due to flaky tests, it undermines trust in our testing process. This could lead us to overlook real issues in the codebase, continuing to merge PRs despite legitimate failures in e2e tests. To maintain confidence in our testing suite and avoid overlooking potential issues, we must ensure that our tests consistently pass, addressing failures promptly and thoroughly.
Testing Instructions
Ensure that the Playwright e2e tests pass.
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).