This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update the sidebar notice we show for incompatible extensions #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' of github.com:woocommerce/woocommerce-blocks into update/10855-sidebar-notice-for-incompatiple-extensions
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/editor-components/incompatible-extension-notice/index.tsx
|
|
Size Change: +592 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
|
@nielslange I gave this a test before doing code review. For some reason I only see the notice with Coinbase. The other test plugins do not show anything in my notice. They are active, I double checked. I also cleared the local storage cache to no avail.
With only 1 incompatibility, should we integrate it into the message rather than append as a list? e.g. I prefer "may be" over "might be" but thats personal preference. If this wording came from design you can ignore me :)
Let me know how to test those plugins properly. |
Thanks for reaching out, @mikejolley. On the screenshot, I see the wording "[...] extension is incompatible [...]" instead of "[...] extension might be incompatible [...]". It appears that this PR is not active, which would explain why you're not seeing the three test plugins. As for the Paystack extension, on my end, I noticed that when installing the Coinbase extension, is automatically gets activated as a payment gateway, while I had to manually activate the Paystack extension. Would you mind double-checking this?
That's definitely an option. I'm just a bit concerned about the readability. Let's have a look at the two possible results.
To me, the first version feels more readable. In a glimpse, I can see which extension might be incompatible.
@ralucaStan You mentioned this wording in #10855 (comment). Was that your suggestion or did a designer suggest the wording?
I created a testing site on https://afraid-goldfish.jurassic.ninja/ on which I tested this PR successfully. I'll send you the credentials via Slack so that you can compare your test site with mine. Here's what I see on my test site: 
|
|
@nielslange ok my bad, checked out and built and its working now as intended.
It would be possible to bolden the name of the extension if concerned about that part standing out in the message. It reads fine to me. My main point was we're shaping a message around a list of 1. I know the original message changes when there is only 1 item, but why bother with a list if its not a list? This is an attention to detail thing. What you've done works fine. I will approve anyway, I don't feel strongly enough about this to hold it up. |
mikejolley
approved these changes
Sep 29, 2023
|
…e-extensions # Conflicts: # package-lock.json
|
Thanks for your review, @mikejolley, and glad to hear that that you've successfully tested the PR. I just adjusted the wording from "might be" to "may be" and changed the logic to show the name of the incompatible extension directly in the notice, if there's only one incompatible extension. We can always switch back to showing a single extension also as a list item, if we receive reports that the notice is not obvious. This is how the notice looks like when there's only one incompatible extension: 
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10855
What
This PR introduces the following two changes:
"The following extension is incompatible with the block-based checkout." to
"The following extensions may be incompatible with the block-based checkout.".
Why
Enhance clarity and user perception:
The adjustment in the wording from “is incompatible” to “might be incompatible” aims to clarify potential impacts and reduce unnecessary user concern over extension incompatibilities, by indicating a possibility rather than a certainty of conflict.
Promote informed decision-making:
By displaying all extensions explicitly declaring incompatibility, we enable users to make informed decisions on extension use, reducing unforeseen disruptions and enhancing user trust and experience.
Encourage proactive conflict resolution:
Clear, comprehensive incompatibility information empowers users and extension developers to proactively address conflicts, likely reducing support requests and fostering a harmonious ecosystem.
Optimize user experience:
These changes are part of our ongoing efforts to minimize friction and promote understanding, enabling users to navigate the system with greater confidence and ease.
Testing Instructions
Test updated text
CoinbaseandPaystackextensions:Test display of incompatible extensions
A → Incompatible Extension,Coinbase,N → Incompatible Extension,PaystackandZ → Incompatible Extensionextensions:Test closing of sidebar notice
Screenshots or screencast
WooCommerce Visibility
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog