This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add table styles for order details #10185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/atomic/blocks/product-elements/rating-stars/index.tsx
assets/js/atomic/blocks/product-elements/rating-stars/support.ts assets/js/blocks/mini-cart/index.tsx assets/js/blocks/mini-cart/mini-cart-contents/edit.tsx assets/js/blocks/order-confirmation/billing-address/index.tsx assets/js/blocks/order-confirmation/downloads/edit.tsx assets/js/blocks/order-confirmation/downloads/index.tsx assets/js/blocks/order-confirmation/shipping-address/index.tsx assets/js/blocks/order-confirmation/status/index.tsx assets/js/blocks/order-confirmation/summary/edit.tsx assets/js/blocks/order-confirmation/summary/index.tsx assets/js/blocks/order-confirmation/totals/edit.tsx assets/js/blocks/order-confirmation/totals/index.tsx |
|
Size Change: +350 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
nielslange
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Thanks for working on this, @mikejolley. While reviewing it, I noticed that the product is not linked in the site editor, but it is linked on the frontend. I also noticed that it's not possible to adjust the color of the product link. Wouldn't it make sense to allow merchants to adjust the link styles as well? 🤔
91bb8ef to
e8d650c
Compare
Base automatically changed from
add/global-styles-order-confirmation-summary-10118
to
feature/blockify-order-confirmation
July 14, 2023 09:09
1b249d7 to
51ad63d
Compare
nielslange
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Hi @mikejolley, thanks for making the link color adjustable. While reviewing the change, I noticed that the adjusted link color is only visible on the frontend, but not on the backend. This forces a merchant to change a look and then verify on the frontend is the color combination looks as expected.
What are your thoughts on displaying the selected link color directly in the site editor?
|
Bodged it. |
|
@nielslange should be fixed now. |
wavvves
approved these changes
Jul 17, 2023
mikejolley
added a commit
that referenced
this pull request
Jul 18, 2023
* Add table styles for order details * __experimentalFontWeight * Add link styles * Handle preview link styles
mikejolley
added a commit
that referenced
this pull request
Aug 14, 2023
* Add table styles for order details * __experimentalFontWeight * Add link styles * Handle preview link styles
tarhi-saad
pushed a commit
that referenced
this pull request
Aug 25, 2023
* Add table styles for order details * __experimentalFontWeight * Add link styles * Handle preview link styles
mikejolley
added a commit
that referenced
this pull request
Sep 1, 2023
* Add table styles for order details * __experimentalFontWeight * Add link styles * Handle preview link styles
mikejolley
added a commit
that referenced
this pull request
Sep 19, 2023
* Add table styles for order details * __experimentalFontWeight * Add link styles * Handle preview link styles
mikejolley
added a commit
that referenced
this pull request
Sep 20, 2023
* Main block types for confirmation * Initial blocks * Styling and placeholders * Make blocks experimental * Update summary icon * Add name/description for status block and missing text descriptions in the block. Closes #10057 * Order confirmation: Convert Order Details Templates to Blocks (#10095) * Move code from templates into the details block * Details -> Totals * Downloads block * Sample content for downloads block * Add block icon * Add conversion template (#10077) * Update inner block name * Add default title constant * Revert "Add default title constant" This reverts commit 1dd3bbf. * Add global styles for order confirmation status block (#10164) * Implement style controls * Prevent link color spilling over onto wrapper * Add styles and remove class names * Remove __experimentalWritingMode * Add global styles for order confirmation summary block (#10179) * Styles for summary * Remove __experimentalWritingMode * Add table styles for order details (#10185) * Add table styles for order details * __experimentalFontWeight * Add link styles * Handle preview link styles * Unauthenticated views for Order Confirmation template (#10414) * Different views by permission * check user id matches when logged out * Add order confirmation wrapper block (#10286) * Add a heading wrapper block * Register the BillingWrapper Block server side * Fix exception 'render_content' error * Add the Billing Wrapper Block to the template * Fix wrong block name error * Fix php error * Conditionally render Billing Address within the Wrapper * Fix parent rendering * Clean up code (remove billing address from the template) * Update titles, descriptions, and icons of the billing Block and inner block * Fix broken block by removing the "parent" keyword * Use a user-friendly title and description for the Billing Wrapper * Update Billing Wrapper Block's title case Co-authored-by: Mike Jolley <mike.jolley@me.com> * Fix PHP failing unit test --------- Co-authored-by: Mike Jolley <mike.jolley@me.com> * Remove "thanks" for authenticated page * Introduce shipping wrapper based on billing wrapper Closes #10053 * Order confirmation block: Verify email address for guest customers (#10567) * Add verify step for guest orders * Render content to pass through block content * Revert package changes * Customer orders cannot use email to verify * Add style controls for order shipping and billing address blocks (#10633) * Order confirmation block styling (#10780) * Add missing heading to order details * Summary block spacing * Update css variables * table styles * Inherit border styles for cells * Alignment and address styles * Add downloads wrapper * Style controls * Fix typo * Update Download Wrapper's Icon * Fix TS error * Disable Download Block's server side rendering in the editor This fixes the loading after each style change from the style controls * Clean up Downloads render functions * Fix client side Downloads Block's table border * Download + Total wrappers and tables styling * small screen * Remove server side render for previews --------- Co-authored-by: Saad Tarhi <saad.trh@gmail.com> * Shorten template description * Update test address data * Avoid leaking order key in permission form * Remove todo * Make email form required. * Remove edit page link * Remove empty columns from address wrapper * Remove IIFE * typo * Update description to mention billing * Adjust link scss * Fix wrapper markup and spacing controls * Add link preview in editor * Add initial E2E setup for the Order Confirmation Block (#10840) * Fix WC_DateTime check * Move form outside of block markup * Add additional information block (#10842) * Add block which contains hooks * Use skeleton for placeholder instead of illustration * Remove duplicate methods * Remove duplicate align tag * Update meta styles * Tests for order confirmation conditional blocks (#10972) * Add tests for conditional blocks * Move setup into test * Add E2E to the the Order Confirmation Block (#10863) * Add editor util functions * Update editor template E2E test * Add the "exact" property for consistency * Skip test Can't get the element in the page. More investigation needed! Skipping for now. * Fix "transformIntoBlocks" logic * Add tests for logged in user * Fix "beforeAll" config * Confirm downloads section is visible when logged in * Create "verifyOrderConfirmationDetails" util function * Add logged in test case * Add Guest user test case * Fix editor e2e testing * Apply a proper teardown * Fix failing tests after logout * Ensure we are logged in before visiting the editor * Ensure to have shipping selected * Wait for changes to be saved on the editor * Ensure shipping options is selected * Remove comment * Ensure we are logged in before going to the admin page * Mark the Order Confirmation as a side effect test * OrderConfirmation blocks are not experimental * resolve merge conflict * Revert package lock changes * Fix enqueue_assets * Fix CSS 404s * Make template tests more robust * Fix page URL for default confirmation page * Try afterEach to log back in * Skip guest/logout use cases Login out causes other tests to fail. We will implement these case when the multiple sign in roles are introduced in the codebase. * Remove tests requiring login out & add comments * Remove unused util functions * Hide confirmation blocks from post editor --------- Co-authored-by: Saad Tarhi <saad.trh@gmail.com> Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds styles for the totals block. This also removes legacy classnames so the new styles can apply without conflicts.
Fixes #10119
Screenshots
Testing
WooCommerce Visibility