This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Home Screen: Update Store Management (Quick Links) icons #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
approved these changes
May 20, 2020
joshuatf
approved these changes
May 20, 2020
There was a problem hiding this comment.
New icons look great! Well done, @mattsherman 
Looks like package-lock.json was committed so that just needs to be dropped or rebased.
@joshuatf I want to make sure I understand things correctly... why would dropping |
a0335a1 to
d8aee95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4396
This PR updates the icons used in the Store Management (Quick Links) card to be those from
@wordpress/icons, which is what was intended in the design.It is a followup to #4350, where the Store Management card was introduced.
Screenshots
Detailed test instructions:
Changelog Note:
No changelog note needed.