-
Notifications
You must be signed in to change notification settings - Fork 144
Home Screen: Add Store Management (Quick Links) card #4350
Conversation
2240250
to
25363d9
Compare
I went the items to test and just noting it down here while I continue the review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @mattsherman and testing well ! Just some comments about a few relatively minor things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattsherman the icons are a part of the WordPress core icons package and should be accessible via the Icon
component. :)
@jameskoster All of the icons used in the design (https://www.figma.com/file/Z2PiNnkhjrUIiR7IrfJRnU/Home-Screen?node-id=970%3A0) are not available in the It would be very helpful if you could provide me with the name of each icon to use, so that I can ensure that things are implemented as desired. Right now, I'm using a combination of |
…commerce-admin into add/homepage-quick-links
@psealock Thanks for the review and feedback! I've addressed your feedback in the latest commits. If you feel the PR is ready to be approved outside of the icon changes, I can always take care of those in a followup PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking fantastic and thanks for the changes. LGTM and good to follow up with icons separately.
Hm, is that the core Icon component? They should be there because I added them. At least, I added the ones that I thought were missing, maybe some others need updating from their Dashicon counterparts 🤔 Here's the explicit list of icons to use;
It looks like the Brush and Pencil icons will need to be updated to match the visual design of the others, but we'll handle that in core :) Sorry for the confusion here. |
@jameskoster Thanks for the links to the icons to use. I think the confusion stemmed from my use of |
Updating of icons will be addressed in #4396
Fixes #4082
This PR adds the new "Store Management" (Quick Links) card to the home screen.
Accessibility
prefers-reduced-motion
Screenshots
Detailed test instructions
wcadmin_home_quick_links_click
Tracks events are recorded, with thetask_name
custom prop set appropriately, every time an item in the list is clicked.Unit tests
Known issues
<List>
component.<QuickLinks>
componentChangelog Note:
Enhancement: New "Store Management" quick links card on WooCommerce home screen.