Handle all loading states within the PhoneNumberCard component
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eason9487 , for the settings page:
Do we want to show the "horizontal divider" line when the loading is in progress? I think it would look nicer, and it would be consistent with the store address UI below it too. |
ecgan
approved these changes
Aug 5, 2021
Comment on lines
+159
to
+172
| /** | ||
| * Renders phone number data in Card UI and is able to edit. | ||
| * | ||
| * @param {Object} props React props. | ||
| * @param {PhoneNumber} props.phoneNumber Phone number data. | ||
| * @param {boolean} [props.isPreview=false] Whether to display as preview UI. | ||
| * @param {boolean|null} [props.initEditing=null] Specify the inital UI state. This prop would be ignored if `isPreview` is true. | ||
| * `true`: initialize with the editing UI. | ||
| * `false`: initialize with the viewing UI. | ||
| * `null`: determine the initial UI state according to the `data.isValid` after the `phoneNumber` loaded. | ||
| * @param {Function} [props.onEditClick] Called when clicking on "Edit" button. | ||
| * If this callback is omitted, it will enter edit mode when clicking on "Edit" button. | ||
| * @param {onPhoneNumberChange} [props.onPhoneNumberChange] Called when inputs of phone number are changed in edit mode. | ||
| */ |
Comment on lines
+185
to
+189
| useEffect( () => { | ||
| if ( loaded && isEditing === null ) { | ||
| setEditing( ! data.isValid ); | ||
| } | ||
| }, [ loaded, data.isValid, isEditing ] ); |
There was a problem hiding this comment.
💅 It took me a while to figure out this relates to your JSDoc comment "determine the initial UI state according to the `data.isValid` after the `phoneNumber` loaded.". Would be good to have a comment to explain this, or even refactor it.
There was a problem hiding this comment.
Added a comment by 63460f7.
eason9487
added a commit
that referenced
this pull request
Aug 6, 2021
Address #934 (comment) Co-authored-by: Gan Eng Chin <ecgan@users.noreply.github.com>
Address #934 (comment) Co-authored-by: Gan Eng Chin <ecgan@users.noreply.github.com>
537da07 to
968ab62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
It's a follow-up for #917 (comment).
PhoneNumberCardcomponent to show more card content as soon as possible.❗ This's a refactor PR and didn't affect the functionality of the Contact Information feature. It could be reviewed and (maybe) merged after the Contact Information is released.
Screenshots:
MC setup
Settings
Detailed test instructions:
To enter the MC setup step 4 directly, it could replace this line in js/src/setup-mc/setup-stepper/saved-setup-stepper.js by
To mock the API response of phone number and add more delay to view the loading state, it could add PHP snippet in google-listings-and-ads.php.
PhoneNumberCardcomponent instead of the parent layer for all casesChangelog entry