init DS1307RTC only if needed #2740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DS1307RTC is only required by USERMOD_RTC and USERMOD_ELEKSTUBE_IPS. If we don't use it, we do not want to execute `Wire.begin();` which configure gpio port 21 et 22 as I2C ports. This created a regression as it was possible to use gpio 21 and 22 for relays.
1 task
|
Hopefully solved in #2737 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS1307RTC is only required by USERMOD_RTC and USERMOD_ELEKSTUBE_IPS.
If we don't use it, we do not want to execute
Wire.begin();which configure gpio port 21 et 22 as I2C ports. This created a regression as it was possible to use gpio 21 and 22 for relays.