Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArtPoll support #2615

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Add ArtPoll support #2615

merged 6 commits into from
Sep 22, 2022

Conversation

4lloyd
Copy link
Contributor

@4lloyd 4lloyd commented Apr 2, 2022

This PR adds support for ArtPoll and ArtPollReply. This solves #417.

At the moment the OEM and ESTA manufacturer code are set to zero. Someone of the WLED team may request these codes, so the device will show up as WLED in lighting consoles. This is not a must for the code to work, but more of a "nice to have".

These codes can be requested via:

The changes were tested on the esp32dev and esp8266_2m platform.

Parts of the code are inspired by the code of: https://github.com/hideakitai/ArtNet. That library also has a MIT license.

@4lloyd 4lloyd changed the title Add ArtPoll support [WIP] Add ArtPoll support Apr 3, 2022
@4lloyd 4lloyd changed the title [WIP] Add ArtPoll support Add ArtPoll support Apr 3, 2022
@Aircoookie
Copy link
Member

Thank you very much! I will likely merge this after #2610

@erhan-
Copy link

erhan- commented Sep 13, 2022

Hello everyone, seems like there are some good news. #2737 is merged. Will these changes be also merged now as told in #417 (comment) ?

Same for #2619

Thanks for your contribution and help.

@Aircoookie Aircoookie changed the base branch from main to 0_14 September 14, 2022 21:16
@Aircoookie
Copy link
Member

Hey, I just pushed a small change, by allocating ArtPollReply on the stack when needed, we can save precious global heap RAM.
Since I lack host software that supports ArtPoll, please test if it still works as intended if you have time.

@Aircoookie Aircoookie merged commit d0189b0 into wled:0_14 Sep 22, 2022
@4lloyd
Copy link
Contributor Author

4lloyd commented Sep 22, 2022

Hey, I just pushed a small change, by allocating ArtPollReply on the stack when needed, we can save precious global heap RAM. Since I lack host software that supports ArtPoll, please test if it still works as intended if you have time.

I tried the change and Art-Net is still working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants