Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ledmap selection to presets. #2541

Closed
wants to merge 1 commit into from
Closed

Added ledmap selection to presets. #2541

wants to merge 1 commit into from

Conversation

blazoncek
Copy link
Collaborator

@blazoncek blazoncek commented Feb 11, 2022

Can close #2275.
Screenshot 2022-02-11 at 14 20 55

@Sturm2002
Copy link

Sturm2002 commented Feb 11, 2022

Files :

ledmap1.json: 
    {"map":[10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0]}
ledmap2.json:
    {"map":[5, 4, 3, 2, 1, 0, 10, 9, 8, 7, 6]}

also tried :

  • without whitespaces
  • "maps" instead of "map"

When creating a new Preset, and selecting a ledmap, the ledmap won't be selected, when you then try to select it again, it still doesnt get applied, and the extended window of the preset won't open.

running on : esp8266 (NodeMCU)
compiled from your Dev branch

Desktop.2022.02.11.-.16.06.47.02.mp4

@blazoncek
Copy link
Collaborator Author

My tests were all successful. There is a bug (in my fork) after saving a preset that UI is not updated but preset still works.
I use map without spaces: {"map":[5,4,3,2,1,0,11,10,9,8,7,6,17,16,15,14,13,12]}.

@blazoncek
Copy link
Collaborator Author

This has been superseded by #2737
Closing.

@blazoncek blazoncek closed this Aug 18, 2022
@blazoncek blazoncek deleted the ledmap-info branch October 10, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow easy selection of ledmap in preset
2 participants