Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider bubble improvements #1685

Closed

Conversation

andyshinn
Copy link
Contributor

@andyshinn andyshinn commented Jan 23, 2021

This improves the slider bubbles from #1378. Closes #1570.

Changes:

  • Ease in/out CSS transition is a bit more pleasing on the eyes.
  • Added to all sliders except custom ones in color picker wheel.
  • On desktop browser the bubble shows on hover instead of click.
  • Minor formatting fixes (separate commit can be removed).
  • Ignoring some venv Python folders to have PlatformIO installed in project easier (separate commit can be removed).

I tried showing the bubbles over the sliders (like Home Assistant) but ran into trouble with z-index. The bubbles get covered up by the top bar and other staytop classes. I couldn't figure that out so maybe for another time.

To fit these better I opened up the columns a bit more by just letting them auto grow. It seemed to looks OK on my desktop and mobile. The downside is there is a gap where the bubble shows since the slider is moved over. Let me know if we'd like to redesign this.

Mobile:
mobile

Desktop:
desktop

@jdtsmith
Copy link

This looks like a great update to me!

@andyshinn andyshinn force-pushed the feature/slider-values-number-two branch from e0e6082 to 4f9d34d Compare March 19, 2021 19:43
@Aircoookie Aircoookie added the keep This issue will never become stale/closed automatically label Jun 7, 2021
@blazoncek
Copy link
Collaborator

@Aircoookie bumping this.
It would be cool if you merged this one in.

@blazoncek
Copy link
Collaborator

This will make it into WLED as part of #2737 where it was merged more than a year ago.
I recommend to close this PR.

@andyshinn
Copy link
Contributor Author

Cool. Are we finally merging the fork in and you will develop / tag on this repo? I was adding support for multiple repo building on WBLD but maybe I don't need to do that now ;)

@blazoncek
Copy link
Collaborator

I hope so. Everything made it in. It is just a matter of polishing things now.

@andyshinn
Copy link
Contributor Author

Great, sounds good. Hope that happens soon!

@andyshinn andyshinn closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep This issue will never become stale/closed automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sliders 0 to 255 setting
4 participants