Added modalAttemptedToDismiss event with tests and docs #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manicantic e2e are failing due to changes in Modal screen. Can you please fix the tests so we can review and merge your PR? |
yogevbd
approved these changes
Jan 12, 2020
|
Awesome PR! thanks |
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
* Added modalAttemptedToDismiss event with tests and docs * Typo on pageSheet modal button label * Update ModalScreen.js * Fixed button testID * Revert label to fix test cases Co-authored-by: Guy Carmeli <guyca@users.noreply.github.com> Co-authored-by: Yogev Ben David <yogevbd@wix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modalAttemptedToDismiss iOs event
Related Issue
Closes #5824
Description
Since version 4.0.3 modal options are added along with swipeToDismiss flag. This event will trigger only when swipeToDismiss flag is set to false and user attempt to swipe down pageSheet modal. ( Which was use case in out app, so that was a motivation to implement this 😄 ).