Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V4] Support DidAttemptToDismiss for pageSheet modals #5824

Closed
manicantic opened this issue Jan 3, 2020 · 3 comments · Fixed by #5832
Closed

[V4] Support DidAttemptToDismiss for pageSheet modals #5824

manicantic opened this issue Jan 3, 2020 · 3 comments · Fixed by #5832

Comments

@manicantic
Copy link
Contributor

Hi, since 4.0.3 there is possibility to set swipeToDismiss under modal options. This is really nice addition, but also implementing DidAttemptToDismiss with a callback would be a great addition to this functionality.
I tried myself to implement this but I am not so good at objective C. But this might helped, in RNNModalManager.m there should be implementation of - (void)presentationControllerDidAttemptToDismiss:(UIPresentationController *)presentationController with getting calling callback passed to options -> modal -> onDismissAttempt or some other property name.

@manicantic manicantic changed the title [V4] Support DidAttemptToDismiss [V4] Support DidAttemptToDismiss for pageSheet modals Jan 3, 2020
@ItsNoHax
Copy link
Collaborator

ItsNoHax commented Jan 7, 2020

Hi @manicantic,

Sounds like a great feature request!
Will tag @yogevbd and @guyca so they can hopefully add it to the backlog.

@manicantic
Copy link
Contributor Author

Hi @ItsNoHax ,
I've just created PR with AttemptedToDismiss event. You can check it out here : #5832

@ItsNoHax
Copy link
Collaborator

ItsNoHax commented Jan 7, 2020

Solid work @manicantic! 💪

I've passed the PR on and it should hopefully be looked at in the next couple days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants