refactor: clarify data request transaction weight formula #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocao
reviewed
Jun 10, 2021
data_structures/src/transaction.rs
Outdated
| @@ -379,20 +384,18 @@ impl DRTransactionBody { | |||
|
|
|||
| /// Data Request Transaction weight | |||
| pub fn weight(&self) -> u32 { | |||
| // DR_weight = DR_size*alpha + W*COMMIT + W*REVEAL*beta + TALLY*beta + W*OUTPUT_SIZE | |||
| // DR_weight = DR_output_size + W*COMMIT + W*REVEAL*beta + TALLY*beta + (W + M)*OUTPUT_SIZE + N*INPUT_SIZE | |||
There was a problem hiding this comment.
Suggested change
| // DR_weight = DR_output_size + W*COMMIT + W*REVEAL*beta + TALLY*beta + (W + M)*OUTPUT_SIZE + N*INPUT_SIZE | |
| // DR_weight = DR_output_size*alpha + W*COMMIT + W*REVEAL*beta + TALLY*beta + (W + M)*OUTPUT_SIZE + N*INPUT_SIZE |
lrubiorod
reviewed
Jun 10, 2021
data_structures/src/transaction.rs
Outdated
|
|
||
| let inputs_len = u32::try_from(self.inputs.len()).unwrap_or(u32::MAX); | ||
| let outputs_len = u32::try_from(self.outputs.len()).unwrap_or(u32::MAX); | ||
| let dr_weight = self.dr_output.weight().saturating_mul(ALPHA); |
There was a problem hiding this comment.
Suggested change
| let dr_weight = self.dr_output.weight().saturating_mul(ALPHA); | |
| let dr_output_size = self.dr_output.weight().saturating_mul(ALPHA); |
mariocao
approved these changes
Jun 11, 2021
lrubiorod
approved these changes
Jun 11, 2021
aesedepece
requested changes
Jun 14, 2021
data_structures/src/transaction.rs
Outdated
Comment on lines
385
to
387
| /// Data Request Transaction weight | ||
| pub fn weight(&self) -> u32 { | ||
| // DR_weight = DR_size*alpha + W*COMMIT + W*REVEAL*beta + TALLY*beta + W*OUTPUT_SIZE | ||
| // DR_weight = DR_output_size*alpha + W*COMMIT + W*REVEAL*beta + TALLY*beta + N*INPUT_SIZE + (W + M)*OUTPUT_SIZE |
There was a problem hiding this comment.
What about moving the formula to the documentation of the function?
aesedepece
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.