Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP for fixing WIP-0007 (or not) about data requests weight #57

Closed
lrubiorod opened this issue May 24, 2021 · 1 comment · Fixed by #59
Closed

WIP for fixing WIP-0007 (or not) about data requests weight #57

lrubiorod opened this issue May 24, 2021 · 1 comment · Fixed by #59
Assignees

Comments

@lrubiorod
Copy link
Contributor

lrubiorod commented May 24, 2021

https://github.com/witnet/WIPs/blob/master/wip-0007.md

@mariocao mariocao changed the title WIP for fixing WIP-0008 (or not) about data requests weight WIP for fixing WIP-0007 (or not) about data requests weight Jun 10, 2021
@mariocao mariocao self-assigned this Jun 10, 2021
@mariocao
Copy link
Contributor

The PR witnet/witnet-rust#1966 clarifies some of the DR weight formula parameters and removes a misplaced factor alpha. This PR does not change the logic as alpha=1. 😄

I will open a WIP with an amendment for the WIP-0007 in order to match the current implementation with what was specified.

DR_weight = DR_size*alpha + W*COMMIT + W*REVEAL*beta + TALLY*beta + (W+M)*OUTPUT_SIZE + N*INPUT_SIZE

While in the WIP-0007 join transactions were highly subsidised by the protocol, the implementation was taking into account the weight of the transaction inputs.

This could create a wrong incentive to create DRs with the only purpose of joining UTXOs and, therefore, reducing the remaining block bucket for legit DRs. Nevertheless, join transactions are still possible by using regular VTTs where inputs weight is much less compared to the outputs.

@aesedepece aesedepece linked a pull request Jun 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants