Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Uint8Array/Uint16Array/Uint32Array for serialize props #4669

Merged
merged 17 commits into from
Sep 21, 2022
Merged

Supports Uint8Array/Uint16Array/Uint32Array for serialize props #4669

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fe53d0c
supports Uint8Array/Uint16Array/Uint32Array
aggre Sep 8, 2022
1a00913
update astro-island to supports the added types
aggre Sep 8, 2022
cfa5823
run changeset
aggre Sep 8, 2022
1a2f12a
apply format
aggre Sep 8, 2022
ee300ec
Merge branch 'main' into main
matthewp Sep 8, 2022
b71eef5
pass metadata through
aggre Sep 9, 2022
b297723
Merge branch 'main' of github.com:withastro/astro into main
aggre Sep 9, 2022
de00021
using Array type
aggre Sep 9, 2022
28998cc
write test cases for serializing Uint8Array/Uint16Array/Uint32Array
aggre Sep 9, 2022
1e3f9b7
fix the broken test cases
aggre Sep 9, 2022
e307288
add type assertion for psychological safety
aggre Sep 9, 2022
e850437
Merge branch 'main' of github.com:withastro/astro into main
aggre Sep 9, 2022
83c41f6
Merge branch 'main' of github.com:withastro/astro into main
aggre Sep 11, 2022
8dd1c60
this changes is minor change
aggre Sep 11, 2022
65e5766
feat: serialize UintArrays directly
natemoo-re Sep 9, 2022
7034c41
Update index.ts
natemoo-re Sep 13, 2022
84bb3a5
Merge branch 'main' into main
natemoo-re Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-ears-compete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be minor as this is technically a new feature, the ability to pass through typed arrays.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it makes sense!

---

astro-island now correctly passes Uint8Array/Uint16Array/Uint32Array
3 changes: 3 additions & 0 deletions packages/astro/src/runtime/server/astro-island.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ declare const Astro: {
5: (value) => new Set(JSON.parse(value, reviver)),
6: (value) => BigInt(value),
7: (value) => new URL(value),
8: (value) => new Uint8Array(Object.values(JSON.parse(value, reviver))),
9: (value) => new Uint16Array(Object.values(JSON.parse(value, reviver))),
10: (value) => new Uint32Array(Object.values(JSON.parse(value, reviver))),
};

const reviver = (propKey: string, raw: string): any => {
Expand Down
12 changes: 12 additions & 0 deletions packages/astro/src/runtime/server/serialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ const PROP_TYPE = {
Set: 5,
BigInt: 6,
URL: 7,
Uint8Array: 8,
Uint16Array: 9,
Uint32Array: 10,
};

function serializeArray(value: any[], metadata: AstroComponentMetadata): any[] {
Expand Down Expand Up @@ -67,6 +70,15 @@ function convertToSerializedForm(
case '[object Array]': {
return [PROP_TYPE.JSON, JSON.stringify(serializeArray(value, metadata))];
}
case '[object Uint8Array]': {
aggre marked this conversation as resolved.
Show resolved Hide resolved
return [PROP_TYPE.Uint8Array, JSON.stringify(serializeArray(value))];
}
case '[object Uint16Array]': {
return [PROP_TYPE.Uint16Array, JSON.stringify(serializeArray(value))];
}
case '[object Uint32Array]': {
return [PROP_TYPE.Uint32Array, JSON.stringify(serializeArray(value))];
}
default: {
if (value !== null && typeof value === 'object') {
return [PROP_TYPE.Value, serializeObject(value, metadata)];
Expand Down