Supports Uint8Array/Uint16Array/Uint32Array for serialize props #4669
Conversation
🦋 Changeset detectedLatest commit: 84bb3a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
Change looks good! I think there's something wrong with our deps as other PRs are failing. Will update this branch once that's fixed. |
|
I just merged some unit tests for prop serialization, please add these to the test in |
|
@matthewp @natemoo-re Thank you for the merge commit and creating tests! I've written additional tests and passed CI, so I think the changes are ready to review again. |
|
Looks great, thank you! |
.changeset/healthy-ears-compete.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'astro': patch | |||
There was a problem hiding this comment.
This should be minor as this is technically a new feature, the ability to pass through typed arrays.
There was a problem hiding this comment.
Thank you, it makes sense!
Changes
new Uint8Array([1,2,3])is handled as{0: 1, 1: 2, 2: 3}and loses the typeTesting
I couldn't find any hydration tests for
astro-island.props. If there is, I will gladly update the test.Docs
This changes doesn't affect the docs.