Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: first implementation for serialized config #13000

Merged
merged 6 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment
  • Loading branch information
ematipico committed Jan 21, 2025
commit 620513bf944ead9db6ac0a33ef4171826de1bf5c
7 changes: 7 additions & 0 deletions packages/astro/src/types/public/manifest.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/**
* **IMPORTANT**: use the `Pick` interface to select only the properties that we want to expose
* to the users. Using blanket types could expose properties that we don't want. So if we decide to expose
* properties, we need to be good at justifying them. For example: why you need this config? can't you use an integration?
* why do you need access to the shiki config? (very low-level confiig)
*/

import type { AstroConfig } from './config.js';

export type SerializedClientBuild = Pick<AstroConfig['build'], 'format' | 'redirects'>;
ematipico marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading