chore: first implementation for serialized config #13000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
86324f2 to
6dd6c1c
Compare
|
We can bikeshed the exact content of the exports later, but overall the approach looks good. |
ascorbic
reviewed
Jan 17, 2025
ascorbic
approved these changes
Jan 20, 2025
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
matthewp
reviewed
Jan 21, 2025
florian-lefebvre
approved these changes
Jan 21, 2025
matthewp
reviewed
Jan 21, 2025
ematipico
added a commit
that referenced
this pull request
Jan 23, 2025
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
ematipico
added a commit
that referenced
this pull request
Jan 23, 2025
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR a first round of implementation of the Stage 2 RFC withastro/roadmap#1099
The PR isn't against
mainand it's meant to test the waters.Important
Let's not focus on the naming of the virtual module, we will use the RFC Stage 3 for that. Focus on the technical implementation and the "expected usage" of the module, and see the information that we want to export from each module make sense
This PR will set the ground work for the Stage 3 RFC
Testing
Added new tests
Docs
Not at this stage