Refactor Twig registration and usage #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
Credit to @SeriousKen for the original work in octobercms/october#3575
Required as of Twig v3
Keeps the {% spaceless %} ... {% endspaceless %} tag available in Twig 3.x for Winter CMS backwards compatibility.
While it was deprecated and removed in Twig 3.x, it appears to work still, but may need some more testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of long standing issues with how Twig is used in Winter, mostly due to pollution of the global twig instance and inconsistent / inaccessible uses of custom Twig environments. This PR aims to fix most if not all of the issues.
An initial attempt at this refactor was made by @SeriousKen in octobercms/october#3575, this PR takes inspiration from that PR and much thanks to @SeriousKen for the initial work on it. Another attempt was made by @mjauvin in octobercms/october#4803 but that didn't address all of the concerns either.
Issues:
Twig::parse()) before rendering Mail content (october/october#3341, october/october#4955