Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register cms twig environment #4803

Closed
wants to merge 1 commit into from
Closed

register cms twig environment #4803

wants to merge 1 commit into from

Conversation

mjauvin
Copy link
Contributor

@mjauvin mjauvin commented Dec 4, 2019

One can now use App::get('twig.environment') to get CMS twig environment.

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 4, 2019

Twig::parse() can now render CMS Twig Extensions as well as system ones.

@LukeTowers
Copy link
Contributor

@mjauvin see #3575, that's the one that should be polished up and tested. Note that we don't want the CMS Twig environment to pollute the global one, I believe that causes issue with the Mail system's Twig environment, especially since it also has "partial" tags.

@mjauvin
Copy link
Contributor Author

mjauvin commented Dec 5, 2019

I find #3575 too complex and I don't really see the point. My simple fix is enough. I agree we should use cms.twig.environment, though.

@mjauvin mjauvin deleted the add-cms-twig-env branch December 9, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants