Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty states for My Sayings and Custom Categories #253

Closed
Uma-mv opened this issue Apr 23, 2020 · 2 comments · Fixed by #491
Closed

Empty states for My Sayings and Custom Categories #253

Uma-mv opened this issue Apr 23, 2020 · 2 comments · Fixed by #491

Comments

@Uma-mv
Copy link

Uma-mv commented Apr 23, 2020

As a vocable app user, I would like to see an empty state message when I have just added a category

NOTE: As of 3/21/22 this is mostly implemented. It is hidden via a feature flag therefore wont appear in the App store and Adhoc schemes. There may be a need for some design updates, but when that is worked on as part of this ticket, we will need to remove the feature flag.

Acceptance Criteria

  • After successfully adding a category, navigating to the category on the home screen display an empty state screen.
  • After successfully adding a category, navigating to the detail view of that category in Settings would display an empty state screen.
  • If there are no My Sayings an empty state screen will be displayed.

Design on Home Screen:
https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable-New?node-id=1%3A141
Design in Settings:
https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable-New?node-id=1%3A1344

@Uma-mv Uma-mv added the v1.4 label Apr 23, 2020
@rc-young rc-young changed the title Empty states Empty states for Custom Categories May 11, 2020
@stevefosterwta stevefosterwta changed the title Empty states for Custom Categories Empty states for My Sayings and Custom Categories Aug 21, 2020
@rhsalas3
Copy link
Contributor

rhsalas3 commented Mar 9, 2022

@SashankPatel
I just reviewed this ticket on the current build from the develop branch. The empty states need to be implemented, for iPad and iOS. The designs seem to be out of date because the "edit category" screen doesn't match what's actually in the app. Should we also make efforts to update the designs, as a form of continuous documentation? Maybe we can chat with the team about it as we move forward.

Otherwise, this ticket looks to be relevant and ready for development. I am removing the 'Needs design review' label and adding 'Ready to Select' to communicate this.

CC: @sgordon1024

@SashankPatel
Copy link
Contributor

SashankPatel commented Mar 23, 2022

Verified on PR: #491 : See PR for test scenarios.

moyerr added a commit that referenced this issue Mar 24, 2022
…yings-empty-state

#253 | Enable and update Empty State views for Sayings & Categories
@rhsalas3 rhsalas3 mentioned this issue Apr 19, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants