Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocable iOS - Empty State text mismatch #481

Closed
SashankPatel opened this issue Mar 18, 2022 · 2 comments · Fixed by #503
Closed

Vocable iOS - Empty State text mismatch #481

SashankPatel opened this issue Mar 18, 2022 · 2 comments · Fixed by #503
Assignees
Labels
bug Something isn't working Ready for Test v1.4

Comments

@SashankPatel
Copy link
Contributor

Describe the bug
There is a mismatch in the empty state text between the code and figma.
App: "This category has no phrases yet"
Figma: "You don't have any phrases saved yet"

After chatting with a designer, it is preferred to have the figma text rather than the text in the app.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the app
  2. Navigate to Settings > Categories and Phrases.
  3. Tap on the + button to add a category.
  4. Proceed with steps to adding a new category.
  5. After Category is added, go into the newly created category and tap on the "Edit Phrases" button

Expected behavior
Empty state to appear with the following design:
https://www.figma.com/file/mNrwUygVhTmuWnKNHHkenR/Vocable---Current?node-id=972%3A8837

Actual behavior
Empty state appears as shown in figma but with the text "This category has no phrases yet"

Device Information
This is device independent

@SashankPatel
Copy link
Contributor Author

Crowdin was updated with the new string. We are looking into how crowdin distributes those changes, i.e. will a PR be automatically generated?

@SashankPatel
Copy link
Contributor Author

CC @moyerr Assigned this ticket to you as well, initially we didn't think there was any work left for #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for Test v1.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants