Skip to content

Commit

Permalink
Remove attempt to set sort_name & display_name.
Browse files Browse the repository at this point in the history
On testing I found that what we were setting was being ignored (otherwise the cleanups
would not have flowed through).

I have done an upstream PR to address length handling in core
civicrm/civicrm-core#11063

I don't think it's pressing for us to address long_name handling (ie.
we can suck that PR in now or wait for the next update) but
removing these 2 lines gets rid of the misleading impression that they
have an effect

Change-Id: I0be0a8883e19378019adf29f9b4cb76add4e812e
  • Loading branch information
eileenmcnaughton authored and ejegg committed Oct 9, 2017
1 parent 95d6879 commit d4963cd
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions sites/all/modules/wmf_civicrm/wmf_civicrm.module
Original file line number Diff line number Diff line change
Expand Up @@ -1079,9 +1079,6 @@ function wmf_civicrm_message_contact_insert( $msg, $contact_id=NULL ) {
$contact[$name] = substr(trim($msg[$name]), 0, 64);
}
}
// @todo this may not be needed as core may handle, but unsure how it handles over-long strings.
$contact['sort_name'] = substr(trim($msg['last_name'] . ', ' . $msg['first_name'], ' ,'), 0, 128);
$contact['display_name'] = substr($msg['first_name'] . ' ' . $msg['last_name'], 0, 128 );
}
if ( strtolower( $msg['contact_type'] ) == "organization" ){
// @todo probably can remove handling for sort name and display name now.
Expand Down

0 comments on commit d4963cd

Please sign in to comment.