CRM-21258 support long display names. #11063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gracefully truncate rather than hard-error if calculated field exceeds DB chars
8ae3739 to
3628dc8
Compare
|
Makes sense to me. Failure is unrelated. |
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Oct 9, 2017
On testing I found that what we were setting was being ignored (otherwise the cleanups would not have flowed through). I have done an upstream PR to address length handling in core civicrm/civicrm-core#11063 I don't think it's pressing for us to address long_name handling (ie. we can suck that PR in now or wait for the next update) but removing these 2 lines gets rid of the misleading impression that they have an effect Change-Id: I0be0a8883e19378019adf29f9b4cb76add4e812e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Gracefully truncate rather than hard-error if calculated field display_name field exceeds DB chars
Before
If you create a contact & the length of the calculated display name (e.g. first_name + " " + last_name) exceeds 128 chars you get a DB error
After
Display field & sort field are truncated rather than a hard error
Comments
This is pretty edge case & likely to be bad data but a db error on a calculated field being too long seems inappropriate