Add ReadableStreamOperations for ServiceWorker #350
Conversation
|
@annevk if you have time. @jungkees fyi I noticed my wording at w3c/ServiceWorker#934 was a bit inconsistent with existing operations. I will create a PR replacing "cancel a reader" with "cancel a ReadableStream" etc. after this change is landed. I'm sorry for the mess... |
| <code data-anolis-spec=streams>ReadFromReadableStreamReader</code>(<var>reader</var>). | ||
|
|
||
| <li><p>Return <var>promise</var>. | ||
| </ol> |
There was a problem hiding this comment.
I think we should inline this and the other operation you introduce by replacing "run these steps" with "return the result of calling ..."
|
This looks good, shall I rebase it for you? |
| <p>To <dfn title=concept-read-chunk-from-ReadableStream>read a chunk</dfn> from a | ||
| <code title=concept-ReadableStream>ReadableStream</code> object with <var>reader</var>, return the | ||
| result of calling | ||
| <code data-anolis-spec=streams>ReadFromReadableStreamReader</code>(<var>reader</var>). |
There was a problem hiding this comment.
Actually, maybe we should not use <code> here? I don't think we do that in HTML.
There was a problem hiding this comment.
<span> seems better for abstract operations.
There was a problem hiding this comment.
Hm, that should be fixed separately with other abstract operations, I think.
This change adds some ReadableStream operations that are used in w3c/ServiceWorker#934.
283179d to
195b9fc
Compare
|
Filed #361. |
|
Sounds good, thanks! |
This change adds some ReadableStream operations that are used in w3c/ServiceWorker#934.