Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadableStream abstract operations markup #361

Closed
yutakahirano opened this issue Aug 10, 2016 · 3 comments · Fixed by #374
Closed

Fix ReadableStream abstract operations markup #361

yutakahirano opened this issue Aug 10, 2016 · 3 comments · Fixed by #374
Assignees
@yutakahirano

Comments

@yutakahirano
Copy link
Member

  • Use <span> instead of <code>.
  • Fix dead links.
@yutakahirano yutakahirano self-assigned this Aug 10, 2016
@yutakahirano yutakahirano mentioned this issue Aug 10, 2016
Merged
@annevk
Copy link
Member

annevk commented Aug 17, 2016

We should also use "." rather than "@" when referencing internal slots.

@annevk
Copy link
Member

annevk commented Aug 23, 2016

I started looking into this and this seems much more broken than I thought. Most abstract operations are just gone.

It would probably be good to get this updated soonish.

@yutakahirano yutakahirano mentioned this issue Aug 24, 2016
Merged
annevk pushed a commit that referenced this issue Aug 25, 2016
@yutakahirano @annevk
Fix ReadableStream operations
2ef920d 
This change fixes the ReadableStream abstract operation markup and names and aligns it with the Streams Standard. Fixes #361.
@annevk annevk mentioned this issue Aug 25, 2016
Closed
@annevk
Copy link
Member

annevk commented Aug 25, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yutakahirano yutakahirano

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ReadableStream operations whatwg/fetch
2 participants
@annevk @yutakahirano