Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Move handling of request 'client' to its own steps #1793

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Editorial: Move handling of request 'client' to its own steps #1793

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee6500f
Move handling of request 'client' to algo
noamr Dec 11, 2024
a2504a2
Update fetch.bs
noamr Dec 15, 2024
e1a478f
Update fetch.bs
noamr Dec 15, 2024
0cbc447
nit
noamr Dec 15, 2024
708d8c1
Update fetch.bs
noamr Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 30 additions & 23 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4279,6 +4279,8 @@ the response. [[!HTTP-CACHING]]

<li><p>Let <var>crossOriginIsolatedCapability</var> be false.

<li><p><a>Populate request from client</a> given <var>request</var>.

<li>
<p>If <var>request</var>'s <a for=request>client</a> is non-null, then:

Expand Down Expand Up @@ -4324,16 +4326,6 @@ the response. [[!HTTP-CACHING]]
<var>request</var>'s <a for=request>body</a> to <var>request</var>'s <a for=request>body</a>
<a for="byte sequence">as a body</a>.

<li><p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>", then set
<var>request</var>'s <a for=request>window</a> to <var>request</var>'s <a for=request>client</a>,
if <var>request</var>'s <a for=request>client</a>'s
<a for="environment settings object">global object</a> is a {{Window}} object; otherwise
"<code>no-window</code>".

<li><p>If <var>request</var>'s <a for=request>origin</a> is "<code>client</code>", then set
<var>request</var>'s <a for=request>origin</a> to <var>request</var>'s <a for=request>client</a>'s
<a for="environment settings object">origin</a>.

<li>
<p>If all of the following conditions are true:

Expand Down Expand Up @@ -4376,19 +4368,6 @@ the response. [[!HTTP-CACHING]]
</ol>
</li>

<li>
<p>If <var>request</var>'s <a for=request>policy container</a> is "<code>client</code>", then:

<ol>
<li><p>If <var>request</var>'s <a for=request>client</a> is non-null, then set
<var>request</var>'s <a for=request>policy container</a> to a
<a lt="clone a policy container">clone</a> of <var>request</var>'s <a for=request>client</a>'s
<a for="environment settings object">policy container</a>. [[!HTML]]

<li><p>Otherwise, set <var>request</var>'s <a for=request>policy container</a> to a new
<a for=/>policy container</a>.
</ol>

<li>
<p>If <var>request</var>'s <a for=request>header list</a>
<a for="header list">does not contain</a> `<code>Accept</code>`, then:
Expand Down Expand Up @@ -4459,6 +4438,34 @@ the response. [[!HTTP-CACHING]]
</ol>
</div>

<div algorithm>
<p>To <dfn>populate request from client</dfn> given a <a for=/>request</a> <var>request</var>:
<ol>
annevk marked this conversation as resolved.
Show resolved Hide resolved
<li><p>If <var>request</var>'s <a for=request>window</a> is "<code>client</code>", then set
<var>request</var>'s <a for=request>window</a> to <var>request</var>'s <a for=request>client</a>,
if <var>request</var>'s <a for=request>client</a>'s
<a for="environment settings object">global object</a> is a {{Window}} object; otherwise
"<code>no-window</code>".
noamr marked this conversation as resolved.
Show resolved Hide resolved

<li><p>If <var>request</var>'s <a for=request>origin</a> is "<code>client</code>", then set
<var>request</var>'s <a for=request>origin</a> to <var>request</var>'s <a for=request>client</a>'s
<a for="environment settings object">origin</a>.

<li>
<p>If <var>request</var>'s <a for=request>policy container</a> is "<code>client</code>", then:
noamr marked this conversation as resolved.
Show resolved Hide resolved

<ol>
<li><p>If <var>request</var>'s <a for=request>client</a> is non-null, then set
<var>request</var>'s <a for=request>policy container</a> to a
<a lt="clone a policy container">clone</a> of <var>request</var>'s <a for=request>client</a>'s
<a for="environment settings object">policy container</a>. [[!HTML]]

<li><p>Otherwise, set <var>request</var>'s <a for=request>policy container</a> to a new
<a for=/>policy container</a>.
</ol></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</ol></div>
</ol>

I'm surprised this is not a build error. I guess Bikeshed parsing just drops it? cc @tabatkins

</ol>
</div>


<h3 id=main-fetch>Main fetch</h3>

Expand Down