Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Move handling of request 'client' to its own steps #1793

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Dec 11, 2024

This doesn't have observable effects at the moment, but is a preparation for deferred fetching where populating the request
from client (specifically policy container) needs to happen before fetching.

(https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@noamr noamr changed the title Move handling of request 'client' to algo Editorial:" Move handling of request 'client' to algo Dec 11, 2024
@noamr noamr changed the title Editorial:" Move handling of request 'client' to algo Editorial: Move handling of request 'client' to algo Dec 11, 2024
@noamr noamr requested a review from annevk December 11, 2024 09:44
@noamr noamr changed the title Editorial: Move handling of request 'client' to algo Editorial: Move handling of request 'client' to its own steps Dec 11, 2024
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo some minor nits.

fetch.bs Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
noamr and others added 3 commits December 15, 2024 12:02
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
fetch.bs Outdated

<li><p>Otherwise, set <var>request</var>'s <a for=request>policy container</a> to a new
<a for=/>policy container</a>.
</ol></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</ol></div>
</ol>

I'm surprised this is not a build error. I guess Bikeshed parsing just drops it? cc @tabatkins

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@annevk annevk merged commit c8a0408 into main Dec 16, 2024
2 checks passed
@annevk annevk deleted the client-populate branch December 16, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants