-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Move handling of request 'client' to its own steps #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamr
changed the title
Move handling of request 'client' to algo
Editorial:" Move handling of request 'client' to algo
Dec 11, 2024
noamr
changed the title
Editorial:" Move handling of request 'client' to algo
Editorial: Move handling of request 'client' to algo
Dec 11, 2024
noamr
changed the title
Editorial: Move handling of request 'client' to algo
Editorial: Move handling of request 'client' to its own steps
Dec 11, 2024
annevk
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo some minor nits.
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
annevk
reviewed
Dec 16, 2024
fetch.bs
Outdated
|
||
<li><p>Otherwise, set <var>request</var>'s <a for=request>policy container</a> to a new | ||
<a for=/>policy container</a>. | ||
</ol></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
</ol></div> | |
</ol> |
I'm surprised this is not a build error. I guess Bikeshed parsing just drops it? cc @tabatkins
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't have observable effects at the moment, but is a preparation for deferred fetching where populating the request
from client (specifically policy container) needs to happen before fetching.
(https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff