-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move cli under lerna package #1225
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but have left some suggestions.
Instead of naming sub package "webpack-cli" we should call it "@webpack-cli/core" as it will go good with the conventional naming of sub packages. Like @babel/cli
, @webpack-cli/core
, etc.
Also we should keep bin
in the main package itself and spawn cli from "core" sub package.
ad43807
to
1845ad8
Compare
This is done because we want to resolve internal packages during e2e without using shim code.
1845ad8
to
4059b2d
Compare
We still need a package called
The main package won't be published on the registry (it has to be private). The |
Co-Authored-By: James George <jamesgeorge998001@gmail.com>
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
This is superb, makes it way easy to setup the project now that it leverages yarn workspaces. Kudos! 🎉 |
What kind of change does this PR introduce?
Refactor. This PR moves the
cli
code under a lerna package. This will help the symlinks between different packages and it will help the release process.Did you add tests for your changes?
No. Tests should all pass after this refactor.
If relevant, did you update the documentation?
No. It should be done in later commits.
Summary
The cli should be under the
lerna
supervision. This is useful because it will help the creation of changelog, tagging, committing and publishing using one single tool.Also, I changed the way the
serve
package retrieves the arguments from the CLI. Instead of referring with a relative path, it now importwebpack-cli
package (note the change inpackage.json
of the cli):And it exposes a getter (
getCoreFlags
) that are passed to the serve command.Does this PR introduce a breaking change?
It should not.
Other information