chore: moved to yarn workspaces to have a better testing suite

This is done because we want to resolve internal packages during e2e without using shim code.

jest.config.js

@@ -0,0 +1,12 @@
+module.exports = {
+    testPathIgnorePatterns: ['<rootDir>/node_modules/'],
+    // transformIgnorePatterns: ['<rootDir>.*(node_modules)(?!.*webpack-cli.*).*$'],
+    testEnvironment: 'node',
+    collectCoverage: true,
+    coverageReporters: ['json', 'html', 'cobertura'],
+    transform: {
+        '^.+\\.(ts)?$': 'ts-jest',
+    },
+    testRegex: ['/__tests__/.*\\.(test.js|test.ts)$', '/test/.*\\.(test.js|test.ts)$'],
+    moduleFileExtensions: ['ts', 'js', 'json'],
+};

lerna.json

@@ -2,6 +2,8 @@
   "lerna": "3.20.2",
   "packages": ["packages/*"],
   "version": "independent",
+  "npmClient": "yarn",
+  "useWorkspaces": true,
   "command": {
     "version": {
       "message": "chore(release): publish %s",

package.json

@@ -3,6 +3,7 @@
   "version": "4.0.0-beta.3",
   "description": "CLI for webpack & friends",
   "license": "MIT",
+  "private": true,
   "repository": {
     "type": "git",
     "url": "https://github.com/webpack/webpack-cli.git"
@@ -26,6 +27,9 @@
     "lib",
     "bin/cli.js"
   ],
+  "workspaces": [
+    "./packages/*"
+  ],
   "scripts": {
     "bootstrap": "npm run clean:all && npm install && lerna bootstrap",
     "build": "tsc",
@@ -109,30 +113,6 @@
       }
     ]
   },
-  "jest": {
-    "testPathIgnorePatterns": [
-      "/node_modules/"
-    ],
-    "testEnvironment": "node",
-    "collectCoverage": true,
-    "coverageReporters": [
-      "json",
-      "html",
-      "cobertura"
-    ],
-    "transform": {
-      "^.+\\.(ts)?$": "ts-jest"
-    },
-    "testRegex": [
-      "/__tests__/.*\\.(test.js|test.ts)$",
-      "/test/.*\\.(test.js|test.ts)$"
-    ],
-    "moduleFileExtensions": [
-      "ts",
-      "js",
-      "json"
-    ]
-  },
   "nyc": {
     "include": [
       "./cli.js",

test/GroupHelper.test.js → packages/cli/__tests__/GroupHelper.test.js

@@ -1,4 +1,4 @@
-const GroupHelper = require('../packages/cli/lib/utils/GroupHelper');
+const GroupHelper = require('../lib/utils/GroupHelper');
 
 describe('GroupHelper', function() {
     it('should return undefined', () => {

test/ZeroConfigGroup.test.js → packages/cli/__tests__/ZeroConfigGroup.test.js

@@ -1,4 +1,4 @@
-const ZeroConfigGroup = require('../packages/cli/lib/groups/ZeroConfigGroup');
+const ZeroConfigGroup = require('../lib/groups/ZeroConfigGroup');
 
 describe('GroupHelper', function() {
     it('should  load the dev zero config', () => {

packages/cli/__tests__/command/external.test.js

@@ -0,0 +1,9 @@
+const ExternalCommand = require('../../lib/commands/external')
+
+describe('external command', () => {
+    it('should check existence of package', () => {
+           const exists =  ExternalCommand.checkIfPackageExists('info')
+
+        expect(exists).toBeFalsy();
+    })
+})

packages/cli/bin/cli.js

@@ -38,7 +38,6 @@ if (!semver.satisfies(process.version, version)) {
 
 const [, , ...rawArgs] = process.argv;
 const { cliArgs, nodeArgs } = parseArgs(rawArgs);
-// eslint-disable-next-line node/no-unpublished-require
 const bootstrapPath = require.resolve('../lib/bootstrap');
 
 execa('node', [...nodeArgs, bootstrapPath, ...cliArgs], { stdio: 'inherit' }).catch(e => {

packages/cli/lib/bootstrap.js

@@ -1,6 +1,5 @@
 const WebpackCLI = require('./webpack-cli');
 const { core, commands } = require('./utils/cli-flags');
-const cmdArgs = require('command-line-args');
 const logger = require('./utils/logger');
 
 require('./utils/process-log');
@@ -61,7 +60,7 @@ async function runCLI(cli, commandIsUsed) {
         return await cli.runCommand(commandIsUsed, ...args);
     } else {
         try {
-            args = cmdArgs(core, { stopAtFirstUnknown: false, partial: true });
+            args = cli.commandLineArgs(core, { stopAtFirstUnknown: false, partial: true });
             if (args._unknown) {
                 resolveNegatedArgs(args);
                 args._unknown
@@ -98,7 +97,7 @@ async function runCLI(cli, commandIsUsed) {
                 const newArgKeys = Object.keys(argsMap).filter(arg => !keysToDelete.includes(argsMap[arg].pos));
                 // eslint-disable-next-line require-atomic-updates
                 process.argv = newArgKeys;
-                args = cmdArgs(core, { stopAtFirstUnknown: false, partial: true });
+                args = cli.commandLineArgs(core, { stopAtFirstUnknown: false, partial: true });
 
                 await cli.run(args, core);
                 process.stdout.write('\n');

packages/cli/lib/commands/external.js

@@ -22,12 +22,15 @@ class ExternalCommand {
         });
     }
 
+    /**
+     *
+     * @param extName
+     * @returns {boolean}
+     */
     static checkIfPackageExists(extName) {
         try {
-            const path = require('path');
-            const pathForCmd = path.resolve(process.cwd(), 'node_modules', packagePrefix, extName);
-            require.resolve(pathForCmd);
-            return pathForCmd;
+            require(`${packagePrefix}/${extName}`);
+            return true;
         } catch (err) {
             return false;
         }
@@ -65,7 +68,7 @@ class ExternalCommand {
         if (!pkgLoc) {
             pkgLoc = await ExternalCommand.promptInstallation(scopeName, name);
         }
-        return pkgLoc ? require(pkgLoc).default(...args) : null;
+        return pkgLoc ? require(scopeName).default(...args) : null;
     }
 }