Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.4 #5036

Merged
merged 13 commits into from
Jun 21, 2022
Merged

1.7.4 #5036

merged 13 commits into from
Jun 21, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 17, 2022

Fixed

Changed

Added

Security

@jdevcs jdevcs added Release 1.x 1.0 related issues labels May 17, 2022
@jdevcs jdevcs self-assigned this May 17, 2022
@render
Copy link

render bot commented May 17, 2022

@coveralls
Copy link

coveralls commented May 17, 2022

Pull Request Test Coverage Report for Build 2536509381

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.517%

Totals Coverage Status
Change from base Build 2497117244: 0.0%
Covered Lines: 3251
Relevant Lines: 4117

💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented May 17, 2022

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@jdevcs jdevcs changed the title 1.7.4-rc.0 1.7.4-rc.1 Jun 8, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Jun 8, 2022

For 1.7.4-rc.1:

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts x
synthetix ~1000 units

@luu-alex luu-alex mentioned this pull request Jun 14, 2022
@luu-alex
Copy link
Contributor

Synthetix test passed for 1.7.4-rc.1 ✔️ , open zepelin testcases had around 80 failing test cases due to attributes not existing on web3.utils.BN due to my BN PR that merged. #5132 This PR fixes it.

@jdevcs jdevcs changed the title 1.7.4-rc.1 1.7.4-rc.2 Jun 16, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Jun 16, 2022

For 1.7.4-rc.2:

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@luu-alex
Copy link
Contributor

For 1.7.4-rc.2:

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@jdevcs jdevcs marked this pull request as ready for review June 21, 2022 14:42
@jdevcs jdevcs changed the title 1.7.4-rc.2 1.7.4 Jun 21, 2022
@wbt
Copy link
Contributor

wbt commented Jun 22, 2022

FYI, this turned out to be a breaking change on nonbreaking semver, as discussed in more detail in the above-linked comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants