Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Dependency update: Upgrade dependency: web3@1.7.1 #4979

Closed
wants to merge 6 commits into from

Conversation

eggplantzzz
Copy link
Contributor

@eggplantzzz eggplantzzz commented Apr 4, 2022

This PR upgrades web3 and it's subpackages to 1.7.3.

  • @truffle/artifactor: 1.5.3 → 1.7.3
  • @truffle/contract: 1.5.3 → 1.7.3
  • @truffle/contract-tests: 1.5.3 → 1.7.3
  • @truffle/core: 1.5.3 → 1.7.3
  • @truffle/dashboard-provider: ^1.6.1 → 1.7.3
  • @truffle/db: 1.5.3 → 1.7.3
  • @truffle/debugger: 1.5.3 → 1.7.3
  • @truffle/decoder: 1.5.3 → 1.7.3
  • @truffle/deployer: 1.5.3 → 1.7.3
  • @truffle/encoder: 1.5.3 → 1.7.3
  • @truffle/environment: 1.5.3 → 1.7.3
  • @truffle/hdwallet-provider: 1.5.3 → 1.7.3
  • @truffle/interface-adapter: 1.5.3 → 1.7.3
  • @truffle/provider: 1.5.3 → 1.7.3
  • truffle: 1.5.3 → 1.7.3

* @truffle/artifactor: 1.5.3 →  1.7.1
* @truffle/contract: 1.5.3 →  1.7.1
* @truffle/contract-tests: 1.5.3 →  1.7.1
* @truffle/core: 1.5.3 →  1.7.1
* @truffle/dashboard-provider: ^1.6.1 →  1.7.1
* @truffle/db: 1.5.3 →  1.7.1
* @truffle/debugger: 1.5.3 →  1.7.1
* @truffle/decoder: 1.5.3 →  1.7.1
* @truffle/deployer: 1.5.3 →  1.7.1
* @truffle/encoder: 1.5.3 →  1.7.1
* @truffle/environment: 1.5.3 →  1.7.1
* @truffle/hdwallet-provider: 1.5.3 →  1.7.1
* @truffle/interface-adapter: 1.5.3 →  1.7.1
* @truffle/provider: 1.5.3 →  1.7.1
* truffle: 1.5.3 →  1.7.1
* @truffle/contract: 1.5.3 →  1.7.1
* @truffle/contract: 1.5.3 →  1.7.1
* @truffle/contract-tests: 1.5.3 →  1.7.1
* @truffle/contract: 1.5.3 →  1.7.1
* @truffle/debugger: 1.5.3 →  1.7.1
* @truffle/codec: 1.5.3 →  1.7.1
* @truffle/contract: 1.5.3 →  1.7.1
* @truffle/core: 1.5.3 →  1.7.1
* @truffle/db: 1.5.3 →  1.7.1
* @truffle/decoder: 1.5.3 →  1.7.1
* @truffle/deployer: 1.5.3 →  1.7.1
* @truffle/encoder: 1.5.3 →  1.7.1
* @truffle/events: 1.5.3 →  1.7.1
* @truffle/external-compile: 1.5.3 →  1.7.1
* @truffle/fetch-and-compile: 1.5.3 →  1.7.1
* @truffle/source-fetcher: 1.5.3 →  1.7.1
* @truffle/source-map-utils: 1.5.3 →  1.7.1
@eggplantzzz eggplantzzz closed this May 3, 2022
@eggplantzzz eggplantzzz deleted the bump-web3 branch May 3, 2022 17:46
@wbt
Copy link
Contributor

wbt commented Jun 22, 2022

@eggplantzzz Might we be able to reopen and potentially merge a version that goes to 1.7.4, or were there particular reasons for this to be closed?

After running an npm audit fix I'm now running into a TypeScript compilation error where the BN types used in some parts of the application are incompatible with the BN types used elsewhere, because the older version of web3 is still using @types/bn.js@4.11.6 while newer versions are using @types/bn.js@^5.1.0. It looks like the change was in this commit just 14 days ago in this PR, released yesterday.

It was another one of those breaking-change-on-nonbreaking-semver that I had earnestly-but-in-vain hoped this cluster of projects had gotten away from. However, I think at Truffle bumping all web3 dependencies to 1.7.4 would likely bring things back into consistency at least for me, and permit Typescript transpilation to succeed again.

@cds-amal
Copy link
Member

cds-amal commented Jun 22, 2022

Hey @wbt we ran into issues with our tests when upgrading to 1.7.1 and currently have a branch working to sort out those issues, and bump to web3 1.7.4.

@wbt
Copy link
Contributor

wbt commented Jun 22, 2022

OK, I subscribed to that. With the web3 release out yesterday not being marked as a breaking change, resolving this has suddenly become an urgent blocker for me and probably for others too who just haven't figured out what's going on yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants