Minor fixes to readable-streams tests for ShadowRealm #48653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…video-frame.any.js VideoFrame is not exposed in ShadowRealm, so there's no point in running this test there. See: tc39/proposal-shadowrealm#396
ricea
reviewed
Oct 17, 2024
In order for tests using this resource to run properly in a ShadowRealm, we need to make a fake setInterval()/clearInterval() if both are not present on the global object. See: tc39/proposal-shadowrealm#396
5718b7f to
b803572
Compare
|
Thanks for the review! Should have all of the feedback incorporated now. |
|
Appreciate the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes for readable-streams tests with incorrect expectations for ShadowRealms:
Reported by @mgaudet in tc39/proposal-shadowrealm#396