Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShadowRealms WPT Failures #396

Closed
mgaudet opened this issue Feb 1, 2024 · 2 comments
Closed

ShadowRealms WPT Failures #396

mgaudet opened this issue Feb 1, 2024 · 2 comments
Assignees
@ptomato
Labels
wpt

Comments

@mgaudet
Copy link

mgaudet commented Feb 1, 2024

Really appreciate the work that's happened to get web interfaces inside a ShadowRealm properly tested. I wanted to highlight some failures that I don't think are implementation specific, but rather test integration specific:

  1. /streams/readable-streams/cancel.any.shadowrealm.html fails because it calls into RandomPushSource, defined here, which uses setInterval.
  2. /streams/readable-streams/owning-type-video-frame.any.shadowrealm.html and friends can't run in a shadow realm because VideoFrame doesn't exist inside one.
@littledan littledan mentioned this issue Feb 1, 2024
Open
49 tasks
@caridy
Copy link
Collaborator

caridy commented Feb 5, 2024

/streams/readable-streams/cancel.any.shadowrealm.html fails because it calls into RandomPushSource, defined here, which uses setInterval.

We should resolve this one once we get setTimeout & co inside the shadow realm.

@caridy caridy added the wpt label Feb 8, 2024
@ptomato ptomato assigned ptomato and unassigned rwaldron Oct 16, 2024
ptomato added a commit to ptomato/wpt that referenced this issue Oct 16, 2024
@ptomato
Disable shadowrealm testing for streams/readable-streams/owning-type-…
8fb0770 
…video-frame.any.js

VideoFrame is not exposed in ShadowRealm, so there's no point in running
this test there.

See: tc39/proposal-shadowrealm#396
ptomato added a commit to ptomato/wpt that referenced this issue Oct 16, 2024
@ptomato
Add fake setInterval to streams/resources/rs-utils.js
5718b7f 
In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

See: tc39/proposal-shadowrealm#396
@ptomato ptomato mentioned this issue Oct 16, 2024
Merged
ptomato added a commit to ptomato/wpt that referenced this issue Oct 17, 2024
@ptomato
Add fake setInterval to streams/resources/rs-utils.js
b803572 
In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

See: tc39/proposal-shadowrealm#396
ptomato added a commit to ptomato/wpt that referenced this issue Oct 18, 2024
@ptomato
Disable shadowrealm testing for streams/readable-streams/owning-type-…
001fb01 
…video-frame.any.js

VideoFrame is not exposed in ShadowRealm, so there's no point in running
this test there.

See: tc39/proposal-shadowrealm#396
ptomato added a commit to ptomato/wpt that referenced this issue Oct 18, 2024
@ptomato
Add fake setInterval to streams/resources/rs-utils.js
434d988 
In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

tc39/proposal-shadowrealm#396
ptomato added a commit to web-platform-tests/wpt that referenced this issue Oct 21, 2024
@ptomato
Disable shadowrealm testing for streams/readable-streams/owning-type-…
4ba09d0 
…video-frame.any.js

VideoFrame is not exposed in ShadowRealm, so there's no point in running
this test there.

See: tc39/proposal-shadowrealm#396
ptomato added a commit to web-platform-tests/wpt that referenced this issue Oct 21, 2024
@ptomato
Add fake setInterval to streams/resources/rs-utils.js
17cb5f2 
In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

See: tc39/proposal-shadowrealm#396
@ptomato
Copy link
Collaborator

ptomato commented Oct 21, 2024

Resolved by web-platform-tests/wpt#48653. Feel free to open more issues or ping me if you discover more such failures.

@ptomato ptomato closed this as completed Oct 21, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 23, 2024
@ptomato @moz-wptsync-bot
Bug 1925102 [wpt PR 48653] - Minor fixes to readable-streams tests fo…
bb1054f 
…r ShadowRealm, a=testonly

Automatic update from web-platform-tests
Disable shadowrealm testing for streams/readable-streams/owning-type-video-frame.any.js

VideoFrame is not exposed in ShadowRealm, so there's no point in running
this test there.

See: tc39/proposal-shadowrealm#396

--
Add fake setInterval to streams/resources/rs-utils.js

In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

See: tc39/proposal-shadowrealm#396

--

wpt-commits: 4ba09d0a817c770ee14d4170a2a3f3ba579f16bc, 17cb5f2c57b75f0d2d5665db9a10c046d9e53900
wpt-pr: 48653
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Oct 23, 2024
@ptomato @moz-wptsync-bot
Bug 1925102 [wpt PR 48653] - Minor fixes to readable-streams tests fo…
742c7d7 
…r ShadowRealm, a=testonly

Automatic update from web-platform-tests
Disable shadowrealm testing for streams/readable-streams/owning-type-video-frame.any.js

VideoFrame is not exposed in ShadowRealm, so there's no point in running
this test there.

See: tc39/proposal-shadowrealm#396

--
Add fake setInterval to streams/resources/rs-utils.js

In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

See: tc39/proposal-shadowrealm#396

--

wpt-commits: 4ba09d0a817c770ee14d4170a2a3f3ba579f16bc, 17cb5f2c57b75f0d2d5665db9a10c046d9e53900
wpt-pr: 48653
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Oct 24, 2024
@ptomato @moz-wptsync-bot
Bug 1925102 [wpt PR 48653] - Minor fixes to readable-streams tests fo…
2173dde 
…r ShadowRealm, a=testonly

Automatic update from web-platform-tests
Disable shadowrealm testing for streams/readable-streams/owning-type-video-frame.any.js

VideoFrame is not exposed in ShadowRealm, so there's no point in running
this test there.

See: tc39/proposal-shadowrealm#396

--
Add fake setInterval to streams/resources/rs-utils.js

In order for tests using this resource to run properly in a ShadowRealm,
we need to make a fake setInterval()/clearInterval() if both are not
present on the global object.

See: tc39/proposal-shadowrealm#396

--

wpt-commits: 4ba09d0a817c770ee14d4170a2a3f3ba579f16bc, 17cb5f2c57b75f0d2d5665db9a10c046d9e53900
wpt-pr: 48653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
wpt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rwaldron @caridy @ptomato @mgaudet