[@container] Change initial value of container-type to 'normal' #34658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 30, 2022
9b13817 to
70b74d2
Compare
Per recent CSSWG resolution [1], the initial value is now 'normal'. The function StyleBuilderConverter::ConvertFlags had hard-coded handling of CSSValueID::kNone which interpreted that to mean "flags=0". Since we now also need kNormal to mean "flags=0", this CL adds a template parameter to indicate which CSSValueID we should treat as zero. This CL also disallows the following values from the <custom-ident> of the container-name property: - normal, which was clearly intended from reading the discussion in [1]. - auto, which is not explicitly mentioned in [1] as something to disallow, but it's aligned with the ambition to disallow none/normal/auto from <custom-ident> in general [2]. [1] w3c/csswg-drafts#7402 [2] w3c/csswg-drafts#7431 Fixed: 1340859 Change-Id: I841303e2b5673c65d69d97522a0a3661e5d1ec24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3736384 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1019597}
70b74d2 to
ad4d199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per recent CSSWG resolution [1], the initial value is now 'normal'.
The function StyleBuilderConverter::ConvertFlags had hard-coded
handling of CSSValueID::kNone which interpreted that to mean "flags=0".
Since we now also need kNormal to mean "flags=0", this CL adds a
template parameter to indicate which CSSValueID we should treat as
zero.
This CL also disallows the following values from the <custom-ident>
of the container-name property:
in [1].
disallow, but it's aligned with the ambition to disallow
none/normal/auto from <custom-ident> in general [2].
[1] w3c/csswg-drafts#7402
[2] w3c/csswg-drafts#7431
Fixed: 1340859
Change-Id: I841303e2b5673c65d69d97522a0a3661e5d1ec24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3736384
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1019597}