-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[@container] Change initial value of container-type to 'normal'
Per recent CSSWG resolution [1], the initial value is now 'normal'. The function StyleBuilderConverter::ConvertFlags had hard-coded handling of CSSValueID::kNone which interpreted that to mean "flags=0". Since we now also need kNormal to mean "flags=0", this CL adds a template parameter to indicate which CSSValueID we should treat as zero. This CL also disallows the following values from the <custom-ident> of the container-name property: - normal, which was clearly intended from reading the discussion in [1]. - auto, which is not explicitly mentioned in [1] as something to disallow, but it's aligned with the ambition to disallow none/normal/auto from <custom-ident> in general [2]. [1] w3c/csswg-drafts#7402 [2] w3c/csswg-drafts#7431 Fixed: 1340859 Change-Id: I841303e2b5673c65d69d97522a0a3661e5d1ec24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3736384 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1019597}
- Loading branch information
1 parent
6ce3bac
commit 470bdba
Showing
9 changed files
with
32 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters