Attempt to fix the deploy to staging #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main conditional makes sure that the github.repository is always 'web-platform-tests/wpt.fyi' Then we can check if the event comes from a PR event or non PR event. - For the PR event, check if a fork and not dependabot - For non PR event, we can let the event happen (which is only the push event according to the events in the `on` section above). Even for the push event, we can let dependabot be the actor since the PR has already been verified by a human and it will have access to the credentials when we merge it. Inspiration: - https://github.com/orgs/community/discussions/26409#discussioncomment-3251818 Fixes: #3237
DanielRyanSmith
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main conditional makes sure that the github.repository is always 'web-platform-tests/wpt.fyi'
Then we can check if the event comes from a PR event or non PR event.
onsection above). Even for the push event, we can let dependabot be the actor since the PR has already been verified by a human and it will have access to the credentials when we merge it.Inspiration:
Fixes: #3237