Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot can't read repo secrets upon manual retry anymore #2928

Open
jcscottiii opened this issue Aug 2, 2022 · 1 comment
Open

Dependabot can't read repo secrets upon manual retry anymore #2928

jcscottiii opened this issue Aug 2, 2022 · 1 comment

Comments

@jcscottiii
Copy link
Collaborator

jcscottiii commented Aug 2, 2022

Previously when dependabot created a PR, it would fail on the deploy to staging part because it could not access the gcloud secret. (Reasons why this happens 1 & 2). As a workaround, a developer with access to the repository could re-run the job. The job would succeed because it used the permissions of the person re-running the pipeline (which had access to the secrets). This is no longer the case. Seems like a new thing that occurred: dependabot/dependabot-core#5464


Example of previous behavior that worked

Example of it not working anymore

In the secrets step for both of them, you'll see that the secret is empty
image


Options

  • Add the secret with the same name to the secrets for dependabot
    • Con: A malicious dependency update could potentially get the secret. Github Docs about it
    • However - Renonvate currently does the same thing and it has access to the secret. PRs
  • Skip the deploy steps (keep the test steps) if it is a dependabot build
    • Con: Stuff going into main could break staging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants