Avoid updating all animation effects on single animation mutation #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
I discovered afterwards that the quoted performance numbers in the description are a bit bogus. Turns out Firefox's performance is heavily influenced by the developer console being open which I was not accounting for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids applying the effects of all Animations when a single Animation's state is modified (e.g. setting currentTime).
This is particularly effective
Performance numbers on Firefox Nightly:
500 calls to element.animate(null, 1000): 1600ms down to 170ms.
The 500 Individual Stars demo (rewritten to use element.animate()): 8.5-9.5s down to 4.5-5s
Test case in #472: 2.5-4s down to 30-50ms