Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the other repos and added them to previous_names #3357

Merged
merged 1 commit into from
Aug 29, 2014

Conversation

rajeshvaya
Copy link
Contributor

This request is in reference to previous pull request - #3330

Added previous_names of other repos

@FichteFoll
Copy link
Collaborator

@phildopus, @rrg, @drikin

@FichteFoll
Copy link
Collaborator

@phildopus, @rrg, @drikin, can you please approve of this?

@wbond
Copy link
Owner

wbond commented Aug 14, 2014

Hey @phildopus, @rrg and @drikin can you review this and agree to replacing your packages with this?

@wbond wbond added the stale label Aug 14, 2014
@FichteFoll
Copy link
Collaborator

Alright, so ...

  • @phildopus has expressed that he's willing to retire his package in the referenced PR, so I say we have his approval.

  • @rrg has not visited github since April, thus I say he's not going to see this soon and it can be expected for people to check their notifications. If they disabled them, their problem. I'd even send a mail to him, but he doesn't have an address on his profile.

  • @drikin said

    Hi all, my plugin is maintenance mode now. If someone else takes a lead of making combined plugin I'm welcome.

Thus, I'm merging this.

@FichteFoll FichteFoll removed the stale label Aug 29, 2014
@FichteFoll FichteFoll merged commit 04c2fa9 into wbond:master Aug 29, 2014
FichteFoll added a commit that referenced this pull request Aug 29, 2014
Merges #3357

Conflicts:
	repository/g.json
	repository/o.json
@drikin
Copy link
Contributor

drikin commented Aug 30, 2014

Sorry for my late notice. Sure, it's fine for me.

@rrg
Copy link
Contributor

rrg commented Mar 5, 2015

Sorry for the delay, I just checked this after someone responded here http://stackoverflow.com/questions/19665615/sublime-text-text-list-of-open-files/19694952#19694952

I'm fine with the change, can you please get this package back to work.

Thanks

@FichteFoll
Copy link
Collaborator

@rrg: @rajeshvaya appears to be active and the last push on https://github.com/rajeshvaya/Sublime-Extended-Tab-Switcher was 4 days ago. Please post issues there, unless he does not respond to them anymore or other issues with maintainer changes arise (or similar).

@rrg
Copy link
Contributor

rrg commented Mar 6, 2015

Sorry I do not understand what the problem is? How do I get my extension back to package manager?

@FichteFoll
Copy link
Collaborator

Edit: Update below.


We try to keep duplicated packages at a minimum because of several reasons, mainly:

  1. If the feature provided is trivial, the user is prompted with different packages all achieving practically the same thing and confused about which he should use.
  2. If the difference is trivial, the user is again confused about which he should use, but the package authors or maintainers are also effectively doubling their work (of maintainance). If they worked together on the same package (either by collaborating or by proposing pull requests) the community would be.
  3. If one pf the authors or maintainers can not keep maintaining his version of a package it is abandoned. With two or more authors collaborating the chance of this happening is reduced.

There are exceptions to this rule in cases where developers simply can't or don't want to work together due to certain reasons or the packages themselves are different enough in that they provide different use cases and would attract different users. However, there might also still be the option of combining these kind of packages by including functionality of one in the other.

However, there is no definitive objective criteria here.

In your particular case, you've been asked about 9 months ago about your stance with your package, if you'd like to continue developing on it, have @rajeshvaya's features be implemented into your package or whatever. Since your package has been merged into ExtendedTabSwitcher as a result of no answer, your package now qualifies as a new package and needs to satisfy the criteria of being a non-duplicate again.

@FichteFoll
Copy link
Collaborator

After looking into your package I realize that your package actually provides different functionality from the other three packages (two of which were merged into one other) in that it provides the open files in a text form, likely for copy and paste purposes. I am not sure why I thought that your package's functionality was too similar to the other ones 9 months ago, but I certainly don't see it now. The functionality of course could be merged into ExtendedTabSwitcher since the have somewhat similar functionality, but it's different enough to warrant being its own package.

Additionally, after a few searches I was not able to find a similar package to this currently in the list, which means you package would satisfy the non-duplicate criteria.

I sincerely apologize for my misjudgment that I did not verify due to the assumption of the merge being correct. Let's continue this in #4169.

@rrg
Copy link
Contributor

rrg commented Mar 7, 2015

Thank you, I'll take a look at the other thread, feel free to close this down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants