Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Tab Switcher plugin for sublime #3330

Merged
merged 1 commit into from
Jun 15, 2014
Merged

Conversation

rajeshvaya
Copy link
Contributor

This plugin is inspired by the default tab switcher in netbeans which displays the open files to choose from on pressing ctrl+alt+tab.

@FichteFoll
Copy link
Collaborator

@rajeshvaya
Copy link
Contributor Author

Hello,

I came across these plugins but they did not have all the features which I wanted to have combined
e.g. Viewing dirty files (unsaved), Sorting files, Ability to change settings from the Menu.

@FichteFoll
Copy link
Collaborator

Would it be possible to work together with any (or possibly all) of @phildopus, @rrg, @drikin? Or maybe you three are okay with @rajeshvaya replacing your plugins if his is better?

We already have 3 plugins doing a very similar thing and I think they can be easily combined into a single package with some configurability.

@rajeshvaya
Copy link
Contributor Author

Hello, Yes I think it will be good to combine the features of all as it will be unfair to @phildopus, @rrg, @drikin if their plugin is replaced.

However I feel @phildopus has almost all the features what I have done. If @phildopus can add the menu configurations from mine and let his plugin be the one. (I am a beginner python developer and his code quality is better)

Or if they agree that my plugin covers all features then mine can be accepted.

@drikin
Copy link
Contributor

drikin commented Jun 13, 2014

Hi all, my plugin is maintenance mode now. If someone else takes a lead of making combined plugin I'm welcome. 👍

@rajeshvaya
Copy link
Contributor Author

Hello all, I have no problem on working on combing all features into one. I will analyze all the code of all 4 repos and try to integrate all into one. If anyone wants to request any additional features let me know I will try to incorporate them as well.

I will update once done.

Thanks

@rajeshvaya
Copy link
Contributor Author

Hello all,

I have combined all the features from all the repos into one. Below is the summary of all the features.

  • View all open files
  • Added configurations to enable the user to view open files filtered to active group level or at window (all files) level
  • Ability to sort all the files
  • Ability to choose the marker character for dirty/unsaved files
  • Config for choosing if or not to display the current active file in the list of open files
  • Configurations for editing all configurations/key bindings from the menu

Updated the README file with the instructions and credits to the contributors

I am not sure if I have to update anything in package_control_channel repo. If I have to update anything let me know.

Thanks.

@i-am-a-paull
Copy link
Contributor

Sorry if I’m a little late to the conversation. I haven’t had much time to work on any ST plugins lately, so any efforts toward consolidating are greatly appreciated. I will gladly retire mine.

On Jun 14, 2014, at 6:43 AM, Rajesh Vaya notifications@github.com wrote:

Hello all,

I have combined all the features from all the repos into one. Below is the summary of all the features.

View all open files
Added configurations to enable the user to view open files filtered to active group level or at window (all files) level
Ability to sort all the files
Ability to choose the marker character for dirty/unsaved files
Config for choosing if or not to display the current active file in the list of open files
Configurations for editing all configurations/key bindings from the menu
Updated the README file with the instructions and credits to the contributors

I am not sure if I have to update anything in package_control_channel repo. If I have to update anything let me know.

Thanks.


Reply to this email directly or view it on GitHub.

@FichteFoll
Copy link
Collaborator

@rajeshvaya, looking good so far. However:

  1. Your tags must be valid semantic versions.

  2. Since I'd like you to merge all existing plugins and @rrg has used the version 1.0.0 before, you must push a higher version than that.

  3. @rrg doesn't seem to be active a lot on github. Let's wait some time before we continue.

  4. In order to make this happen you need to do this with your pull request:

    1. Remove the packages that we want to remove from the repo.
    2. Add the packages' names to a previous_names array of your package data so that old users will be redirected.

    Finally, in your repo, you should add an update message so that the users updating to your package are informed about changes in behavior, maintainer and stuff.

@rajeshvaya
Copy link
Contributor Author

Hello,

Just few questions, The link on "semantic versions" was broken, can you send me any other link or let me know what it should be like?

Secondly, by higher version you mean the version i specify in the tags/release ? or in the package data?

Thanks

@FichteFoll FichteFoll merged commit 8c62ffd into wbond:master Jun 15, 2014
@FichteFoll
Copy link
Collaborator

Okay, seems like Github is broken and just merged both of your pull requests (with one click) ... reverting

@FichteFoll
Copy link
Collaborator

Oh, never mind. You included the only commit of this PR in the other PR, reverted it there, merged master and THEN did your changes.

That meant that this PR was closed since the commit was merged from the other one. Sooo ... your fault I guess (and mine for not checking). You had to make a new one anyway.

Edit: For the future, please create new branches for new pull requests based on the most recent master.

@rajeshvaya
Copy link
Contributor Author

Hello,

I am sorry for this inconvenience. I am fairly new with pull requests and I guess I did it wrong.
I will rectify it. Thanks for your co-operation

@greneholt
Copy link
Contributor

I must say I was rather annoyed to find that my installation of GotoOpenFile had been silently replaced with Extended Tab Switcher, which has different default key bindings and doesn't even seem to work (I just get IndexError's). Please implement some sort of mechanism to alert users before replacing one of their packages with something else.

@FichteFoll
Copy link
Collaborator

There is the functionality to provide update messages which could have been displayed, since this can actually be considered an update as well, just a more extensive one. However, many package developers do not make use of that feature and while I try to recommend such a notice, I might miss it sometimes since I've been doing this review process for quite a while now and sometimes just assume that things will turn out well. (Actually, this is the first time I've heard of problems.)

@greneholt
Copy link
Contributor

If Extended Tab Switcher worked I'm sure it wouldn't have been a problem. For now I've just manually installed GotoOpenFile, as it is perfectly sufficient for my needs.

@Blasz
Copy link

Blasz commented Apr 2, 2015

This plugin (Extended Tab Switcher) doesn't even work on windows (if at all) - rajeshvaya/Sublime-Extended-Tab-Switcher#9.

GotoOpenFile is exactly what I want and having to manually install it is a pain.

@FichteFoll
Copy link
Collaborator

@rajeshvaya, please address this issue.

@rajeshvaya
Copy link
Contributor Author

Hello All, Sorry for the late response. I will look into it and fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants