-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How-To Guide for Using a Property Model #500
How-To Guide for Using a Property Model #500
Conversation
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 171 171
Lines 14018 14018
=======================================
Hits 13279 13279
Misses 739 739 Continue to review full report at Codecov.
|
Here is the log output from the doc test that failed. Looks like the test doesn't like the fact that you are displaying output...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start. Need to resolve the failing test (see suggestions above). Also may be nice to have a little more explanation in the beginning.
Ok, so now only the test with python 3.8 is failing. A warning is being output (see below) that is causing the current error. """ There should be a way in .rst files using Maybe @lbianchi-lbl can help out a bit more here. |
Ok, thanks! I work part-time, so I'll look into this first thing tomorrow morning. |
I think @bknueven might have some ideas as well. |
We're still using idaes-ext 2.5.5, but the runners are getting Pyomo 6.4, which contains a newer version of PyNumero. I think the easiest thing is to resolve #503, going to at least 2.0.0a1 (or IDAES/idaes-pse@2cb6df0) and also enforce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Nice job on your first PR, @MarcusHolly! I'm approving this even though we need to resolve the issue with the failed check.
@MarcusHolly - just one change I want to suggest (even though I approved already). Can you move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: bknueven <30801372+bknueven@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all tests are passing now. I am not sure why there was that one python 3.8 failure before, but everything seems good now.
Fixes/Addresses:
Issue #275
Summary/Motivation:
This PR adds a How-To guide for using a property model.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: