Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update our Fork and Tags for IDAES #503

Closed
2 tasks
aladshaw3 opened this issue Apr 26, 2022 · 5 comments
Closed
2 tasks

Need to update our Fork and Tags for IDAES #503

aladshaw3 opened this issue Apr 26, 2022 · 5 comments
Assignees
Labels
Priority:High High Priority Issue or PR

Comments

@aladshaw3
Copy link
Collaborator

IDAES will be changing a lot of its paths for import statements for specific unit models and properties that we will be dependent on (see the comment and test failures in #502).

After updating the fork and tags for installing the latest IDAES, we will likely see a lot of depreciation warnings for those import statements. We will also need to then go through our code base and update those import paths.

  • Update fork of IDAES and tag for installation
  • Update all import paths in WaterTAP to IDAES models/properties
@aladshaw3
Copy link
Collaborator Author

I am not sure what the priority on this will be, but we should discuss this at the next meeting so we understand how much of a change this is and what this may 'break' in WaterTAP.

@bknueven
Copy link
Contributor

Based on the issues in #500, we should ideally update to at least this commit: IDAES/idaes-pse@2cb6df0 (or just 2.0.0a1), and also update our Pyomo requirement to pyomo>=6.3 to get the latest version of PyNumero.

@adam-a-a
Copy link
Contributor

Based on the issues in #500, we should ideally update to at least this commit: IDAES/idaes-pse@2cb6df0 (or just 2.0.0a1), and also update our Pyomo requirement to pyomo>=6.3 to get the latest version of PyNumero.

Yes, and I would consider this high priority since this is something that can hold up simple PRs.

@bknueven bknueven added the Priority:High High Priority Issue or PR label Apr 27, 2022
@adam-a-a adam-a-a mentioned this issue Apr 28, 2022
@ksbeattie
Copy link
Contributor

I will update the fork and put a tag on the 2cb6df0 hash, and open a PR to update our setup.py to use that.

@aladshaw3
Copy link
Collaborator Author

Closed by #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

6 participants