-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Examples of Unit Model Costing Documentation #1373
Adding Examples of Unit Model Costing Documentation #1373
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 339 339
Lines 35890 35890
=======================================
Hits 33682 33682
Misses 2208 2208 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: superscripts and subscripts are not showing correctly un USD and in the parameter description. Also couldn't find CSTR, CSTR injection in the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only suggestion would be to delete the section in the CSTR page mentioned in my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
References
Aim to include at least one reference in most cases, but delete this section if no references used for cost relationships/default values
This section needs to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this - I just forgot to add it.
Fixes/Resolves:
Issue #1360
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: